From da258d913db8cafdf20644db8eca1e6e9ce0e8b1 Mon Sep 17 00:00:00 2001 From: Gerrit User 35587 <35587@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 13 Dec 2022 05:30:55 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (2 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 10239 \u003c10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35587\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 35587 \u003c35587@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35587\u003e replied on the change"} --- 8637cc49a02d38ba34ceb136aa636d8c5023b50a | 36 ++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/8637cc49a02d38ba34ceb136aa636d8c5023b50a b/8637cc49a02d38ba34ceb136aa636d8c5023b50a index 90f3574..243aa11 100644 --- a/8637cc49a02d38ba34ceb136aa636d8c5023b50a +++ b/8637cc49a02d38ba34ceb136aa636d8c5023b50a @@ -17,6 +17,24 @@ "revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "75e9b232_9fc6a1fc", + "filename": "futurist/_futures.py", + "patchSetId": 1 + }, + "lineNbr": 412, + "author": { + "id": 35587 + }, + "writtenOn": "2022-12-13T05:30:55Z", + "side": 1, + "message": "waitall() comes down to eventlet.event.Event.wait(). Reading the comment below, it seems to support multiple calls.\n\nhttps://github.com/eventlet/eventlet/blob/85290a11dd5c5f511a45f4010b512eedfef87000/eventlet/event.py#L17-L18\n\nBut of course it is possible to modify GreenThreadPoolExecutor so that it will have the additional flag whether shutdown with wait\u003dTrue is already called or not. Is it better to do so?", + "parentUuid": "5ef2128d_2bae57b9", + "revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": false, "key": { @@ -33,6 +51,24 @@ "message": "I think there is a way to mark a test as skipped (self.skip or some exception)", "revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "661c8df4_6341fd9c", + "filename": "futurist/tests/test_executors.py", + "patchSetId": 1 + }, + "lineNbr": 147, + "author": { + "id": 35587 + }, + "writtenOn": "2022-12-13T05:30:55Z", + "side": 1, + "message": "Changed it to skip in patch set 2.", + "parentUuid": "575493aa_435ac425", + "revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file