92 lines
3.2 KiB
Plaintext
92 lines
3.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5ef2128d_2bae57b9",
|
|
"filename": "futurist/_futures.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 10239
|
|
},
|
|
"writtenOn": "2022-12-12T16:18:46Z",
|
|
"side": 1,
|
|
"message": "Are you sure these are safe to call twice?",
|
|
"revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "75e9b232_9fc6a1fc",
|
|
"filename": "futurist/_futures.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 35587
|
|
},
|
|
"writtenOn": "2022-12-13T05:30:55Z",
|
|
"side": 1,
|
|
"message": "waitall() comes down to eventlet.event.Event.wait(). Reading the comment below, it seems to support multiple calls.\n\nhttps://github.com/eventlet/eventlet/blob/85290a11dd5c5f511a45f4010b512eedfef87000/eventlet/event.py#L17-L18\n\nBut of course it is possible to modify GreenThreadPoolExecutor so that it will have the additional flag whether shutdown with wait\u003dTrue is already called or not. Is it better to do so?",
|
|
"parentUuid": "5ef2128d_2bae57b9",
|
|
"revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6c498c17_610a3c34",
|
|
"filename": "futurist/_futures.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 35587
|
|
},
|
|
"writtenOn": "2022-12-13T09:52:49Z",
|
|
"side": 1,
|
|
"message": "I missed checking about self.delayed_work.join() in the comment above, but yet this came down to eventlet.event.Event.wait() via eventlet.queue.Queue.join(), so the both two lines seems to be okay to be called many times.\n\nhttps://github.com/eventlet/eventlet/blob/85290a11dd5c5f511a45f4010b512eedfef87000/eventlet/queue.py#L461",
|
|
"parentUuid": "75e9b232_9fc6a1fc",
|
|
"revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "575493aa_435ac425",
|
|
"filename": "futurist/tests/test_executors.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 147,
|
|
"author": {
|
|
"id": 10239
|
|
},
|
|
"writtenOn": "2022-12-12T16:18:46Z",
|
|
"side": 1,
|
|
"message": "I think there is a way to mark a test as skipped (self.skip or some exception)",
|
|
"revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "661c8df4_6341fd9c",
|
|
"filename": "futurist/tests/test_executors.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 147,
|
|
"author": {
|
|
"id": 35587
|
|
},
|
|
"writtenOn": "2022-12-13T05:30:55Z",
|
|
"side": 1,
|
|
"message": "Changed it to skip in patch set 2.",
|
|
"parentUuid": "575493aa_435ac425",
|
|
"revId": "8637cc49a02d38ba34ceb136aa636d8c5023b50a",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |