openstack/glance-specs
Code Issues Proposed changes

Replace deprecated library function os.popen() with subprocess

Browse Source 
os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.

Change-Id: I761503490899c47f875e4ca07c4e941eb53390b8
Closes-Bug: #1529836
This commit is contained in:
Harshada Mangesh Kakad 2016-01-14 05:59:08 -08:00
parent 6308b04ec1
commit 040ecfe5dd
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/conf.py
View File

@ -12,6 +12,7 @@
# serve to show the default.
import datetime
import subprocess
import sys
import os
@ -132,8 +133,10 @@ html_theme = 'nature'
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.