Update patch set 2

Patch Set 2:

(3 comments)

Patch-set: 2
CC: Gerrit User 27615 <27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_27615\u003e replied on the change"}
This commit is contained in:
Gerrit User 27615 2024-04-29 08:36:08 +00:00 committed by Gerrit Code Review
parent fe70fa6fb2
commit 0886ef5b61
1 changed files with 67 additions and 0 deletions

View File

@ -0,0 +1,67 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a36466aa_0fcbdcec",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 27615
},
"writtenOn": "2024-04-29T08:36:08Z",
"side": 1,
"message": "one question inline.",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7c0cbbfd_fad4b0c8",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 20,
"author": {
"id": 27615
},
"writtenOn": "2024-04-29T08:36:08Z",
"side": 1,
"message": "nit: is",
"range": {
"startLine": 20,
"startChar": 59,
"endLine": 20,
"endChar": 63
},
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "af999459_d0340fdc",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 47,
"author": {
"id": 27615
},
"writtenOn": "2024-04-29T08:36:08Z",
"side": 1,
"message": "os-brick does have a mechanism of checking if a device is mounted[1] and mount it if not already mounted[2].\nThe question I have is, will the NFS share be mounted always? is there a case where we would like to unmount the nfs share? since that functionality isn\u0027t provided by os-brick.\n\n[1] https://github.com/openstack/os-brick/blob/master/os_brick/remotefs/remotefs.py#L104-L106\n[2] https://github.com/openstack/os-brick/blob/master/os_brick/remotefs/remotefs.py#L110",
"range": {
"startLine": 44,
"startChar": 0,
"endLine": 47,
"endChar": 75
},
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}