Update patch set 3
Patch Set 3:
(5 comments)
Patch-set: 3
Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9303\u003e replied on the change"}
This commit is contained in:
Gerrit User 9303
Gerrit Code Review
parent
0e22231a5a
commit
2eeac230d1
|
|
@ -17,6 +17,23 @@
|
|||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "c752c136_4b54b2e5",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 9303
|
||||
},
|
||||
"writtenOn": "2024-05-10T05:55:50Z",
|
||||
"side": 1,
|
||||
"message": "Thank you Dan for review, please find inline replies for your comments.",
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -34,6 +51,24 @@
|
|||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "01d8942d_fe4d3534",
|
||||
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 36,
|
||||
"author": {
|
||||
"id": 9303
|
||||
},
|
||||
"writtenOn": "2024-05-10T05:55:50Z",
|
||||
"side": 1,
|
||||
"message": "AFAIK, healthcheck middleware can check if specified disabled path exists or not [1], and glance doesn\u0027t have its own implementation to override custom behavior.\n\n[1] https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/disable_by_file.py#L82\n\n\nSo are you suggesting we can define our own plugin using helathcheck middleware for this purpose?",
|
||||
"parentUuid": "4d6780cd_b716f560",
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -51,6 +86,24 @@
|
|||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0064c1a7_9eee1658",
|
||||
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 9303
|
||||
},
|
||||
"writtenOn": "2024-05-10T05:55:50Z",
|
||||
"side": 1,
|
||||
"message": "So, in this (k8s) deployment, while starting the service if NFS is available, service starts and reports healthy, but after that if mount disappears due to some unknown reasons it goes to unhealthy state.",
|
||||
"parentUuid": "ea75c3de_b5807e15",
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -68,6 +121,24 @@
|
|||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e9ef2ffb_0b99be67",
|
||||
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 77,
|
||||
"author": {
|
||||
"id": 9303
|
||||
},
|
||||
"writtenOn": "2024-05-10T05:55:50Z",
|
||||
"side": 1,
|
||||
"message": "In short are you suggesting to use os.path.ismount() method or explicitly read /proc/mount and check mount path in it?",
|
||||
"parentUuid": "3d6dc77b_971bfeae",
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -114,6 +185,30 @@
|
|||
},
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "98e79966_b7a9d2cc",
|
||||
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 102,
|
||||
"author": {
|
||||
"id": 9303
|
||||
},
|
||||
"writtenOn": "2024-05-10T05:55:50Z",
|
||||
"side": 1,
|
||||
"message": "Need to verify this behavior using healthcheck middleware",
|
||||
"parentUuid": "9213de84_318172bd",
|
||||
"range": {
|
||||
"startLine": 102,
|
||||
"startChar": 38,
|
||||
"endLine": 102,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue