From 2f813a90977f128f2d0789aeba6f867a61b44170 Mon Sep 17 00:00:00 2001 From: Flavio Percoco Date: Fri, 13 May 2016 14:59:11 -0500 Subject: [PATCH] Remove reviewers section from template When this template was created, the intention behind this section was to know the got-to people for specific specs. Questions like: Who should I ping if I need more Glance insights? Who should I ping to actually get reviews? etc Unfortunately, The reviewers section has turned to a field mostly used to highlight people interested in a specific feature. More often than not, the revieweres listed in this section are not the ones reviewing the patches for the spec. In addition to the above, this section currently separates core reviewers from non-cores. This separation brings no value to this section nor the spec itself. Regardless the size of the team, this section is not bringing any value to the process as reviewers not in this list can as well review the patches as much as the reviewers listed there can also not review the patches. Change-Id: I973d97e82f4561de8d4ac33672494eae0fc15925 --- specs/template.rst | 21 --------------------- tests/test_titles.py | 3 +-- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/specs/template.rst b/specs/template.rst index 1b244ddc..5b37edb1 100644 --- a/specs/template.rst +++ b/specs/template.rst @@ -256,27 +256,6 @@ Primary assignee: Other contributors: -Reviewers ---------- - -Who are the main point of contact for reviewing this piece of functionality? -These individuals would have more familiarity with the active development -efforts and status of the patch sets. A spec should have at least two -reviewers. - -At least, one of the reviewers should be a core member in the corresponding -project. This individual could also serve as a liaison for the developer(s); -thus providing them a better communication medium with the other core -reviewers, as needed. - -Core reviewer(s): - - - -Other reviewer(s): - - - Work Items ---------- diff --git a/tests/test_titles.py b/tests/test_titles.py index 1dd350e5..baa5d3e8 100644 --- a/tests/test_titles.py +++ b/tests/test_titles.py @@ -80,8 +80,7 @@ class TestTitles(testtools.TestCase): self.filename != 'specs/juno/example.rst'): self.assertEqual(2, len(titles[impl]), self.filename) else: - self.assertEqual(3, len(titles[impl]), self.filename) - self.assertIn('Reviewers', titles[impl], self.filename) + self.assertEqual(2, len(titles[impl]), self.filename) self.assertIn('Assignee(s)', titles[impl]) self.assertIn('Work Items', titles[impl])