openstack/glance-specs
Code Issues Proposed changes

Adds requirement of 'Reviewers' to the specs

Browse Source 
This patch adds "Reviewers" subsection under the "Implementation"
section in the template. Thus, all the specs following this commit
would need to suffice the Reviewers requirement for the approval.
Email [0] sent to the ML, corresponding to this requirement.

[0] http://lists.openstack.org/pipermail/openstack-dev/2014-October/048918.html

Change-Id: I396b7fad247a2e115bf9c7b7634240c15355ab20
This commit is contained in:
Nikhil Komawar 2014-10-28 15:10:07 -04:00
parent 113c8a55f1
commit a5d6588adb
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
specs/template.rst
View File

@ -248,6 +248,27 @@ Primary assignee:
Other contributors:
<launchpad-id or None>
Reviewers
---------
Who are the main point of contact for reviewing this piece of functionality?
These individuals would have more familiarity with the active development
efforts and status of the patch sets. A spec should have at least two
reviewers.
At least, one of the reviewers should be a core member in the corresponding
project. This individual could also serve as a liasion for the developer(s);
thus providing them a better communication medium with the other core
reviewers, as needed.
Core reviewer(s):
<launchpad-id or None>
<launchpad-id or None>
Other reviewer(s):
<launchpad-id or None>
<launchpad-id or None>
Work Items
----------

12
tests/test_titles.py
View File

@ -72,7 +72,16 @@ class TestTitles(testtools.TestCase):
impl = 'Implementation'
self.assertIn(impl, titles)
self.assertEqual(2, len(titles[impl]))
# NOTE(nikhil_k): Reviewers subsection is expected in specs
#which are not in the juno directory. One exception is the
#spec specs/juno/example.rst which is auto loaded from the
#template.rst file.
if (self.filename.startswith('specs/juno') and
self.filename != 'specs/juno/example.rst'):
self.assertEqual(2, len(titles[impl]), self.filename)
else:
self.assertEqual(3, len(titles[impl]), self.filename)
self.assertIn('Reviewers', titles[impl], self.filename)
self.assertIn('Assignee(s)', titles[impl])
self.assertIn('Work Items', titles[impl])
@ -97,6 +106,7 @@ class TestTitles(testtools.TestCase):
filter(lambda x: not x.endswith('index.rst'),
glob.glob('specs/*/*')))
for filename in files:
self.filename = filename
self.assertTrue(filename.endswith(".rst"),
"spec's file must uses 'rst' extension.")
with open(filename) as f: