openstack
/
glance-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 4523 \u003c4523@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4523\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9303 \u003c9303@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4523\u003e replied on the change"}
This commit is contained in:
Gerrit User 4523 2024-04-30 20:00:44 +00:00 committed by Gerrit Code Review
parent a6fc624053
commit b631d1ad61
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
158ac627364485b553d76a19adaf355f21bc9ec7
View File

@ -93,6 +93,24 @@
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ff4a93b3_96dd0e14",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 32,
"author": {
"id": 4523
},
"writtenOn": "2024-04-30T20:00:44Z",
"side": 1,
"message": "This is a different thing and isn\u0027t needed, I\u0027m referring to the fsid that identifies any linux FS, not an NFS-specific field.\n\nThe os.statvfs result has it on Python 3.7+, but it isn\u0027t present in the string representation of the result:\n\n \u003e\u003e\u003e import os\n \u003e\u003e\u003e a \u003d os.statvfs(\u0027/home/eharney\u0027)\n \u003e\u003e\u003e print(a)\n os.statvfs_result(f_bsize\u003d4096, f_frsize\u003d4096, f_blocks\u003d82289991, f_bfree\u003d12370212, f_bavail\u003d8171812, f_files\u003d20971520, f_ffree\u003d16287191, f_favail\u003d16287191, f_flag\u003d4096, f_namemax\u003d255)\n \u003e\u003e\u003e print(a.f_fsid)\n 11174108811353590924\n \nhttps://docs.python.org/3/library/os.html#os.statvfs",
"parentUuid": "1710012f_fe7c5d1b",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {