Update patch set 3
Patch Set 3: (1 comment) Patch-set: 3 Attention: {"person_ident":"Gerrit User 4393 \u003c4393@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 4523 \u003c4523@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change"}
This commit is contained in:
parent
9d33b36b08
commit
c1f3fdf449
|
@ -52,6 +52,24 @@
|
|||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "9952fe44_ff0d4c40",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 4393
|
||||
},
|
||||
"writtenOn": "2024-05-10T14:19:13Z",
|
||||
"side": 1,
|
||||
"message": "Yes, but it can\u0027t tell the difference between two different NFS mounts and it assumes that it\u0027s right at startup. You could go unhealthy any time it changes, but that means if there was some delay between startup and mounting, you\u0027d constantly think it was becoming unhealthy when in reality it was the opposite.\n\nBut yeah, my primary point here is that I think we need to expose this via healthcheck and not by making image operations report that the user did something wrong. I\u0027d prefer something more stable and predictable like a marker, but the mechanism by which we report it is the important thing. If using fsid ends up too flaky, we could move to a marker file without changing the behavior.\n\nI will say, however, that nova now prefers a scenario where a uuid identity file is pre-provisioned in its own state directory by deployment tools for similar reasons. This is a similar arrangement so there is prior art here.",
|
||||
"parentUuid": "9d07742b_36015d39",
|
||||
"revId": "52923f9fdde9e2e63e3bf667f30900ca8f7281f5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
Loading…
Reference in New Issue