Update patch set 2
Patch Set 2:
(5 comments)
Patch-set: 2
Attention: {"person_ident":"Gerrit User 28271 \u003c28271@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28271\u003e replied on the change"}
This commit is contained in:
Gerrit User 28271
Gerrit Code Review
parent
504f135af6
commit
d0fc8abb8e
|
|
@ -40,6 +40,30 @@
|
|||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f867bfa4_abf18441",
|
||||
"filename": "specs/2024.2/approved/glance/standardized_image_encryption.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 14,
|
||||
"author": {
|
||||
"id": 28271
|
||||
},
|
||||
"writtenOn": "2024-04-30T08:24:16Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "f6c0bfbb_ca9fc2cb",
|
||||
"range": {
|
||||
"startLine": 14,
|
||||
"startChar": 31,
|
||||
"endLine": 14,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -63,6 +87,30 @@
|
|||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "156dc8e3_ef364cd1",
|
||||
"filename": "specs/2024.2/approved/glance/standardized_image_encryption.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 28271
|
||||
},
|
||||
"writtenOn": "2024-04-30T08:24:16Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "86788b8c_a4524115",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 58,
|
||||
"endLine": 73,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -86,6 +134,30 @@
|
|||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "1eb7432a_c8594305",
|
||||
"filename": "specs/2024.2/approved/glance/standardized_image_encryption.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 28271
|
||||
},
|
||||
"writtenOn": "2024-04-30T08:24:16Z",
|
||||
"side": 1,
|
||||
"message": "I think we should discuss this in the Glance meeting - We do have the concern that people might upload images with other container formats than qcow or raw and set all the encryption parameters. In this case there has to be checks in Cinder and Nova to not use these images. But allowing the upload of a not usable image would be a bad user experience imho.",
|
||||
"parentUuid": "3930b7c9_629f20f5",
|
||||
"range": {
|
||||
"startLine": 92,
|
||||
"startChar": 34,
|
||||
"endLine": 92,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -120,6 +192,24 @@
|
|||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "362fec5d_5681c1e2",
|
||||
"filename": "specs/2024.2/approved/glance/standardized_image_encryption.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 137,
|
||||
"author": {
|
||||
"id": 28271
|
||||
},
|
||||
"writtenOn": "2024-04-30T08:24:16Z",
|
||||
"side": 1,
|
||||
"message": "I wrote it up in more detail, we do not want to change Cinders workflow, rather want Nova to use the same. So we want to rename the cinder_encryption_key_deletion_policy. And have a combination with the check through the secret consumers.",
|
||||
"parentUuid": "2896c473_8e9c1a13",
|
||||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -143,6 +233,30 @@
|
|||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "980e4c15_9f14e2ff",
|
||||
"filename": "specs/2024.2/approved/glance/standardized_image_encryption.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 228,
|
||||
"author": {
|
||||
"id": 28271
|
||||
},
|
||||
"writtenOn": "2024-04-30T08:24:16Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "46957d42_aa4b870b",
|
||||
"range": {
|
||||
"startLine": 228,
|
||||
"startChar": 21,
|
||||
"endLine": 228,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "fc0e4cd737cf50ffcfb4cac02e000bad544d847a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue