From d3e34471f1d0cb85d8b6e06ae27012bef9f50acf Mon Sep 17 00:00:00 2001 From: Chris Yeoh Date: Wed, 29 Oct 2014 12:38:19 +1030 Subject: [PATCH] Add requirement for APIImpact flag Adds a requirement for an APIImpact flag in the commit message for a proposed spec if it proposes changes to the Glance REST API. This will make it much easier for people such as the API WG who want to review API changes across OpenStack to find and review proposed API changes. Change-Id: Ic83a797b3feae28052abba78ac9abc4a07f4063e --- specs/template.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/specs/template.rst b/specs/template.rst index f671d1af..0deef603 100644 --- a/specs/template.rst +++ b/specs/template.rst @@ -40,6 +40,14 @@ Some notes about using this template: having to look at additional files which can not be viewed in gerrit. It will also allow inline feedback on the diagram itself. +* If your specification proposes any changes to the Glance REST API such + as changing parameters which can be returned or accepted, or even + the semantics of what happens when a client calls into the API, then + you should add the APIImpact flag to the commit message. Specifications with + the APIImpact flag can be found with the following query: + + https://review.openstack.org/#/q/status:open+project:openstack/glance-specs+message:apiimpact,n,z + Problem description ===================