openstack
/
glance-specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(4 comments)

Patch-set: 2
CC: Gerrit User 25402 <25402@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 25402 2024-05-02 17:05:16 +00:00 committed by Gerrit Code Review
parent 44b0f9ae9e
commit f67092bda5
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
158ac627364485b553d76a19adaf355f21bc9ec7
View File

@ -40,6 +40,23 @@
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a6d31cc2_5516514f",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 29,
"author": {
"id": 25402
},
"writtenOn": "2024-05-02T17:05:16Z",
"side": 1,
"message": "Are these going to be optional for the filesystem driver?\ne.g. you can enable the `NFS` mode and do some additional check, but let also the `File` driver keep the old behavior so that a different entity (k8s) can take care about ensuring that NFS is always available (e.g. using liveness probes or similar mechanisms).",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -170,6 +187,23 @@
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cddbf587_e2dec27c",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 25402
},
"writtenOn": "2024-05-02T17:05:16Z",
"side": 1,
"message": "Is",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -186,6 +220,40 @@
"message": "Perf impact would be trivial with the approach I mentioned above.",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "55b96006_115c571b",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 97,
"author": {
"id": 25402
},
"writtenOn": "2024-05-02T17:05:16Z",
"side": 1,
"message": "In a k8s related environment, I think we do not need those parameters in the config because Glance won\u0027t even start if the share is not available, so I assume this is required for a deployment in a context !\u003d k8s.",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "eb03f4c8_ad333510",
"filename": "specs/2024.2/approved/glance_store/improve-filesystem-driver.rst",
"patchSetId": 2
},
"lineNbr": 122,
"author": {
"id": 25402
},
"writtenOn": "2024-05-02T17:05:16Z",
"side": 1,
"message": "is the idea to adopt the same cinder mechanism for NFS?",
"revId": "158ac627364485b553d76a19adaf355f21bc9ec7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}