openstack
/
glance
Code Issues Proposed changes

Cinder: Remove ambiguous warning 

In case of Cinder store, when updating location of a legacy image,
we call cinder store to perform the update.
If the operation fails, we log a warning in glance which states:

"Not able to update location url <url> of legacy image due to unknown issues."

Since glance doesn't have knowledge about the actual issue occurred
during the location update, we log this ambiguous warning which is not
useful for operators to debug the actual issue.

The responsibility of logging the warning should be delegated to
glance store (like done here[1]) since it can point to the right
issue as it knows which operation failed exactly.

This patch removes the warning and further warnings should be added
to glance store only.

[1] https://review.opendev.org/c/openstack/glance_store/+/911005

Change-Id: I24b14812a2a15675beacee720d722c2f3a2b252b
This commit is contained in:
Rajat Dhasmana 2024-04-08 23:41:23 +05:30
parent 0bcd6cd71c
commit 3f7b51653a
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
glance/common/store_utils.py
View File

@ -234,9 +234,6 @@ def _update_cinder_location_and_store_id(context, loc):
loc['metadata']['store'] = "%s" % store
return
LOG.warning(_LW("Not able to update location url '%s' of legacy image "
"due to unknown issues."), uri)
def get_updated_store_location(locations):
for loc in locations: