openstack/glance
Code Issues Proposed changes

Remove the digest_algorithm option

Browse Source 
This option has had no effect since the removal of native SSL support in
06b2465f59 .

Change-Id: I7ad94bd2be45a25c9c1dccc552fa9110fc4862aa
This commit is contained in:
Cyril Roelandt 2024-03-19 23:14:36 +01:00
parent 309ca3aec2
commit 46a95f77e3
4 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
doc/source/configuration/configuring.rst
View File

@ -1703,22 +1703,6 @@ load balancer URL would be used for this value.
``public_endpoint=<None|URL>``
Optional. Default: ``None``
Configuring Glance digest algorithm
-----------------------------------
Digest algorithm that will be used for digital signature. The default
is sha256. Use the command::
openssl list-message-digest-algorithms
to get the available algorithms supported by the version of OpenSSL on the
platform. Examples are "sha1", "sha256", "sha512", etc. If an invalid
digest algorithm is configured, all digital signature operations will fail and
return a ValueError exception with "No such digest method" error.
``digest_algorithm=<algorithm>``
Optional. Default: ``sha256``
Configuring http_keepalive option
---------------------------------

5
glance/common/config.py
View File

@ -530,6 +530,11 @@ Related options:
""")),
cfg.StrOpt('digest_algorithm',
default='sha256',
deprecated_for_removal=True,
deprecated_since="Dalmatian",
deprecated_reason=_("""
This option has had no effect since the removal of native SSL support.
"""),
help=_("""
Digest algorithm to use for digital signature.

3
glance/tests/unit/common/test_wsgi.py
View File

@ -732,9 +732,6 @@ class GetSocketTestCase(test_utils.BaseTestCase):
self.useFixture(fixtures.MonkeyPatch(
"glance.common.wsgi.time.time",
mock.Mock(side_effect=[0, 1, 5, 10, 20, 35])))
self.useFixture(fixtures.MonkeyPatch(
"glance.common.wsgi.utils.validate_key_cert",
lambda *x: None))
wsgi.CONF.tcp_keepidle = 600
@mock.patch.object(prefetcher, 'Prefetcher')

10
releasenotes/notes/deprecate-digest_algorithm-7cab4ef4240c522f.yaml Normal file
View File

@ -0,0 +1,10 @@
---
deprecations:
- |
The ``digest_algorithm`` configuration option has been deprecated in this
release and is subject to removal at the beginning of the F development
cycle, following the
`OpenStack standard deprecation policy
<https://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html>`_.
This option has had no effect since the removal of native SSL support.