openstack/glance
Code Issues Proposed changes

Adds missing error msg for HTTPNotFound exception

Browse Source 
Fixes bug 1199373

Change-Id: Ie1e554bd192c90de420672e4b87c489b8ffffc85
This commit is contained in:
Aswad Rangnekar 2013-07-11 08:30:49 -07:00
parent daa572dd9e
commit 5884ca4825
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glance/api/v2/images.py
View File

@ -165,7 +165,7 @@ class ImagesController(object):
except exception.NotFound as e: except exception.NotFound as e:
msg = ("Failed to find image %(image_id)s to delete" % locals()) msg = ("Failed to find image %(image_id)s to delete" % locals())
LOG.info(msg) LOG.info(msg)
raise webob.exc.HTTPNotFound() raise webob.exc.HTTPNotFound(explanation=msg)
class RequestDeserializer(wsgi.JSONRequestDeserializer): class RequestDeserializer(wsgi.JSONRequestDeserializer):

8
glance/registry/api/v1/members.py
View File

@ -46,7 +46,7 @@ class Controller(object):
except exception.NotFound: except exception.NotFound:
msg = _("Image %(id)s not found") msg = _("Image %(id)s not found")
LOG.info(msg % {'id': image_id}) LOG.info(msg % {'id': image_id})
raise webob.exc.HTTPNotFound() raise webob.exc.HTTPNotFound(msg)
except exception.Forbidden: except exception.Forbidden:
# If it's private and doesn't belong to them, don't let on # If it's private and doesn't belong to them, don't let on
# that it exists # that it exists
@ -80,7 +80,7 @@ class Controller(object):
except exception.NotFound: except exception.NotFound:
msg = _("Image %(id)s not found") msg = _("Image %(id)s not found")
LOG.info(msg % {'id': image_id}) LOG.info(msg % {'id': image_id})
raise webob.exc.HTTPNotFound() raise webob.exc.HTTPNotFound(msg)
except exception.Forbidden: except exception.Forbidden:
# If it's private and doesn't belong to them, don't let on # If it's private and doesn't belong to them, don't let on
# that it exists # that it exists
@ -193,7 +193,7 @@ class Controller(object):
except exception.NotFound: except exception.NotFound:
msg = _("Image %(id)s not found") msg = _("Image %(id)s not found")
LOG.info(msg % {'id': image_id}) LOG.info(msg % {'id': image_id})
raise webob.exc.HTTPNotFound() raise webob.exc.HTTPNotFound(msg)
except exception.Forbidden: except exception.Forbidden:
# If it's private and doesn't belong to them, don't let on # If it's private and doesn't belong to them, don't let on
# that it exists # that it exists
@ -253,7 +253,7 @@ class Controller(object):
except exception.NotFound: except exception.NotFound:
msg = _("Image %(id)s not found") msg = _("Image %(id)s not found")
LOG.info(msg % {'id': image_id}) LOG.info(msg % {'id': image_id})
raise webob.exc.HTTPNotFound() raise webob.exc.HTTPNotFound(msg)
except exception.Forbidden: except exception.Forbidden:
# If it's private and doesn't belong to them, don't let on # If it's private and doesn't belong to them, don't let on
# that it exists # that it exists