openstack/glance
Code Issues Proposed changes

Merge "Use HostAddressOpt for opts that accept IP and hostnames"

Browse Source
This commit is contained in:
Jenkins 2017-03-13 19:23:23 +00:00 committed by Gerrit Code Review
commit 7580d817da
3 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glance/common/config.py
View File

@ -584,9 +584,9 @@ Related options:
* data_api * data_api
""")), """)),
cfg.StrOpt('pydev_worker_debug_host', cfg.HostAddressOpt('pydev_worker_debug_host',
sample_default='localhost', sample_default='localhost',
help=_(""" help=_("""
Host address of the pydev server. Host address of the pydev server.
Provide a string value representing the hostname or IP of the Provide a string value representing the hostname or IP of the

13
glance/common/wsgi.py
View File

@ -56,16 +56,9 @@ from glance.i18n import _, _LE, _LI, _LW
bind_opts = [ bind_opts = [
# NOTE(dharinic): Since ``bind_host`` accepts symbolic names cfg.HostAddressOpt('bind_host',
# mapped to IP address apart from IP addresses, we use default='0.0.0.0',
# ``StrOpt`` as against ``IPOpt`` for backward compatibility help=_("""
# reasons. We do not use ``HostnameOpt`` as it would prevent the
# opt from accepting IPv6 addresses.
# TODO(dharinic): Change the Opt type upon resolution of
# bug-1619044
cfg.StrOpt('bind_host',
default='0.0.0.0',
help=_("""
IP address to bind the glance servers to. IP address to bind the glance servers to.
Provide an IP address to bind the glance server to. The default Provide an IP address to bind the glance server to. The default

5
glance/registry/__init__.py
View File

@ -23,8 +23,9 @@ from glance.i18n import _
registry_addr_opts = [ registry_addr_opts = [
cfg.StrOpt('registry_host', default='0.0.0.0', cfg.HostAddressOpt('registry_host',
help=_(""" default='0.0.0.0',
help=_("""
Address the registry server is hosted on. Address the registry server is hosted on.
Possible values: Possible values: