openstack
/
glance
Code Issues Proposed changes

Use FakePolicyEnforcer for deserialization tests 

The tasks unit tests that test the RequestDeserializer
are using the real policy engine.  They should be using
a mock because we're testing the deserialization, not the
policies.

Closes-bug: #1852354

Change-Id: I35bdacd154b2c8d18ce268a5e6e8aba710e41108
This commit is contained in:
Brian Rosmaita 2019-11-12 18:58:23 -05:00
parent e45d5e3b92
commit 7c85bdcf83
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glance/tests/unit/v2/test_tasks_resource.py
View File

@ -569,7 +569,9 @@ class TestTasksDeserializer(test_utils.BaseTestCase):
def setUp(self):
super(TestTasksDeserializer, self).setUp()
self.deserializer = glance.api.v2.tasks.RequestDeserializer()
self.policy = unit_test_utils.FakePolicyEnforcer()
self.deserializer = glance.api.v2.tasks.RequestDeserializer(
policy_engine=self.policy)
def test_create_no_body(self):
request = unit_test_utils.get_fake_request()