openstack
/
glance
Code Issues Proposed changes

Remove incorrect doccomments about there being a default for the host 

parameter, fix misdocumented default port, and remove handling of missing
parameters in BaseClient, because the values are always specified by the
subclass's __init__.
This commit is contained in:
Ewan Mellor 2011-01-04 16:27:06 +00:00 committed by Tarmac
parent 39e1a3cc44 30e66f20ae
commit 87432b2ecd
2 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
glance/client.py
View File

@ -70,18 +70,16 @@ class BaseClient(object):
"""A base client class"""
DEFAULT_PORT = 9090
def __init__(self, host, port=None, use_ssl=False):
def __init__(self, host, port, use_ssl):
"""
Creates a new client to some service.
:param host: The host where service resides (defaults to 0.0.0.0)
:param port: The port where service resides (defaults to 9090)
:param use_ssl: Should we use HTTPS? (defaults to False)
:param host: The host where service resides
:param port: The port where service resides
:param use_ssl: Should we use HTTPS?
"""
self.host = host
self.port = port or int(self.DEFAULT_PORT)
self.port = port
self.use_ssl = use_ssl
self.connection = None
@ -147,14 +145,13 @@ class Client(BaseClient):
"""Main client class for accessing Glance resources"""
DEFAULT_HOST = '0.0.0.0'
DEFAULT_PORT = 9292
def __init__(self, host, port=None, use_ssl=False):
"""
Creates a new client to a Glance API service.
:param host: The host where Glance resides (defaults to 0.0.0.0)
:param host: The host where Glance resides
:param port: The port where Glance resides (defaults to 9292)
:param use_ssl: Should we use HTTPS? (defaults to False)
"""

4
glance/registry/client.py
View File

@ -41,8 +41,8 @@ class RegistryClient(BaseClient):
"""
Creates a new client to a Glance Registry service.
:param host: The host where Glance resides (defaults to 0.0.0.0)
:param port: The port where Glance resides (defaults to 9292)
:param host: The host where Glance resides
:param port: The port where Glance resides (defaults to 9191)
:param use_ssl: Should we use HTTPS? (defaults to False)
"""