openstack
/
glance
Code Issues Proposed changes

Fix server start ping timeout for functional tests 

When we run the functional tests using 'tox -epy27',
the functional tests keeps failing due to ping timeout
that happens after server starts (api, registry etc.,)
in order to run the functional tests. Could make the tests
pass only after increasing the ping timeout.

This minor patch fixes ping timeout issue by increasing the timeout
value from 10 to 30 seconds for ensuring consistent success of
functional tests. Found any value lesser than 30 secs still continue
to fail the tests.

Closes-bug: #1497508
Change-Id: If1c5fc69ae34c976de2a0c5e9e70810b5b994491
This commit is contained in:
Venkatesh Sampath 2015-09-15 08:18:44 +05:30
parent 878c6a6599
commit 9cb3fa7408
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glance/tests/functional/__init__.py
View File

@ -813,7 +813,7 @@ class FunctionalTest(test_utils.BaseTestCase):
except socket.error:
return False
def wait_for_servers(self, servers, expect_launch=True, timeout=10):
def wait_for_servers(self, servers, expect_launch=True, timeout=30):
"""
Tight loop, waiting for the given server port(s) to be available.
Returns when all are pingable. There is a timeout on waiting
@ -822,7 +822,7 @@ class FunctionalTest(test_utils.BaseTestCase):
:param servers: Glance server ports to ping
:param expect_launch: Optional, true iff the server(s) are
expected to successfully start
:param timeout: Optional, defaults to 3 seconds
:param timeout: Optional, defaults to 30 seconds
:return: None if launch expectation is met, otherwise an
assertion message
"""