openstack/glance
Code Issues Proposed changes

Correct typo in config option choices

Browse Source 
A typo in the oslo.config 'choices' for the output_format config
option definition for the image conversion plugin in the
interoperable image import workflow prevents conversion to the
vmdk format.  This patch corrects the typo and regenerates the
sample image import conf file.

Change-Id: I1836a46d969aab8ce09967db63d66f215d2cc920
Closes-bug: #1809462
Related-bug: #1805765
This commit is contained in:
Brian Rosmaita 2018-12-21 09:29:17 -05:00
parent 8ee37b7d7c
commit a22f02b653
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
etc/glance-image-import.conf.sample
View File

@ -20,7 +20,7 @@
# Possible values:
# * qcow2
# * raw
# * vdmk
# * vmdk
#
# Related Options:
# * disk_formats
@ -28,7 +28,7 @@
# Possible values:
# qcow2 - <No description provided>
# raw - <No description provided>
# vdmk - <No description provided>
# vmdk - <No description provided>
#output_format = raw
@ -60,6 +60,10 @@
# * Any provided Task object name to be included
# in to the flow.
# (list value)
#
# This option has a sample default set, which means that
# its actual default value may vary from the one documented
# below.
#image_import_plugins = [no_op]

4
glance/async_/flows/plugins/image_conversion.py
View File

@ -32,7 +32,7 @@ LOG = logging.getLogger(__name__)
conversion_plugin_opts = [
cfg.StrOpt('output_format',
default='raw',
choices=('qcow2', 'raw', 'vdmk'),
choices=('qcow2', 'raw', 'vmdk'),
help=_("""
Desired output format for image conversion plugin.
@ -46,7 +46,7 @@ the conversion and import will fail.
Possible values:
* qcow2
* raw
* vdmk
* vmdk
Related Options:
* disk_formats