Merge "Move from using _ builtin to using glance.i18n _"

glance/api/authorization.py

@@ -18,6 +18,9 @@ import copy
 
 from glance.common import exception
 import glance.domain.proxy
+from glance import i18n
+
+_ = i18n._
 
 
 def is_image_mutable(context, image):

glance/api/common.py

@@ -24,6 +24,7 @@ from glance import i18n
 from glance.openstack.common import log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/api/middleware/context.py

@@ -20,9 +20,11 @@ import webob.exc
 from glance.api import policy
 from glance.common import wsgi
 import glance.context
+from glance import i18n
 from glance.openstack.common import local
 import glance.openstack.common.log as logging
 
+_ = i18n._
 
 context_opts = [
     cfg.BoolOpt('owner_is_tenant', default=True,

glance/api/middleware/version_negotiation.py

@@ -29,7 +29,7 @@ import glance.openstack.common.log as logging
 CONF = cfg.CONF
 
 LOG = logging.getLogger(__name__)
-
+_ = i18n._
 _LW = i18n._LW
 
 

glance/api/policy.py

@@ -29,7 +29,7 @@ import glance.openstack.common.log as logging
 from glance.openstack.common import policy
 
 LOG = logging.getLogger(__name__)
-
+_ = i18n._
 _LI = i18n._LI
 _LW = i18n._LW
 

glance/api/v1/controller.py

@@ -17,11 +17,13 @@ import glance_store as store
 import webob.exc
 
 from glance.common import exception
+from glance import i18n
 import glance.openstack.common.log as logging
 import glance.registry.client.v1.api as registry
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 
 class BaseController(object):

glance/api/v1/images.py

@@ -50,6 +50,7 @@ import glance.openstack.common.log as logging
 import glance.registry.client.v1.api as registry
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/api/v1/members.py

@@ -22,10 +22,12 @@ from glance.api.v1 import controller
 from glance.common import exception
 from glance.common import utils
 from glance.common import wsgi
+from glance import i18n
 import glance.openstack.common.log as logging
 import glance.registry.client.v1.api as registry
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 CONF = cfg.CONF
 CONF.import_opt('image_member_quota', 'glance.common.config')
 

glance/api/v1/upload_utils.py

@@ -28,6 +28,7 @@ import glance.registry.client.v1.api as registry
 
 CONF = cfg.CONF
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/api/v2/image_data.py

@@ -28,6 +28,7 @@ import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 
 

glance/api/v2/images.py

@@ -36,6 +36,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LW = i18n._LW
 
 CONF = cfg.CONF

glance/api/v2/metadef_namespaces.py

@@ -38,6 +38,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LW = i18n._LW
 _LI = i18n._LI

glance/api/v2/metadef_objects.py

@@ -34,6 +34,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 

glance/api/v2/metadef_properties.py

@@ -34,6 +34,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 

glance/api/v2/metadef_resource_types.py

@@ -34,6 +34,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 

glance/api/v2/tasks.py

@@ -36,6 +36,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LW = i18n._LW
 
 CONF = cfg.CONF

glance/api/versions.py

@@ -20,7 +20,9 @@ from oslo.serialization import jsonutils
 import webob.dec
 
 from glance.common import wsgi
+from glance import i18n
 
+_ = i18n._
 
 versions_opts = [
     cfg.StrOpt('public_endpoint', default=None,

glance/cmd/__init__.py

@@ -16,4 +16,3 @@
 from glance import i18n
 
 i18n.enable_lazy()
-i18n.install('glance')

glance/cmd/control.py

@@ -44,7 +44,9 @@ from oslo.utils import units
 from six.moves import xrange
 
 from glance.common import config
+from glance import i18n
 
+_ = i18n._
 
 CONF = cfg.CONF
 

glance/cmd/replicator.py

@@ -33,6 +33,7 @@ from glance import i18n
 from glance.openstack.common import log
 
 LOG = log.getLogger(__name__)
+_ = i18n._
 _LI = i18n._LI
 _LE = i18n._LE
 _LW = i18n._LW

glance/common/auth.py

@@ -33,10 +33,12 @@ from oslo.serialization import jsonutils
 import six.moves.urllib.parse as urlparse
 
 from glance.common import exception
+from glance import i18n
 import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 
 class BaseStrategy(object):

glance/common/client.py

@@ -48,9 +48,11 @@ from six.moves import xrange
 from glance.common import auth
 from glance.common import exception
 from glance.common import utils
+from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 # common chunk size for get and put
 CHUNKSIZE = 65536

glance/common/config.py

@@ -27,8 +27,11 @@ import os
 from oslo.config import cfg
 from paste import deploy
 
+from glance import i18n
 from glance.version import version_info as version
 
+_ = i18n._
+
 paste_deploy_opts = [
     cfg.StrOpt('flavor',
                help=_('Partial name of a pipeline in your paste configuration '

glance/common/exception.py

@@ -19,6 +19,10 @@
 import six
 import six.moves.urllib.parse as urlparse
 
+from glance import i18n
+
+_ = i18n._
+
 _FATAL_EXCEPTION_FORMAT_ERRORS = False
 
 

glance/common/location_strategy/__init__.py

@@ -18,8 +18,11 @@ import copy
 from oslo.config import cfg
 import stevedore
 
+from glance import i18n
 import glance.openstack.common.log as logging
 
+_ = i18n._
+
 location_strategy_opts = [
     cfg.StrOpt('location_strategy', default='location_order',
                help=_("This value sets what strategy will be used to "

glance/common/location_strategy/store_type.py

@@ -19,6 +19,10 @@ from oslo.config import cfg
 import six
 import six.moves.urllib.parse as urlparse
 
+from glance import i18n
+
+_ = i18n._
+
 store_type_opts = [
     cfg.ListOpt("store_type_preference",
                 default=[],

glance/common/property_utils.py

@@ -23,6 +23,7 @@ from oslo.config import cfg
 
 import glance.api.policy
 from glance.common import exception
+from glance import i18n
 from glance.openstack.common import log as logging
 from glance.openstack.common import policy
 
@@ -30,6 +31,7 @@ from glance.openstack.common import policy
 # we must set manually for compatibility with py26
 CONFIG = ConfigParser.SafeConfigParser(dict_type=OrderedDict)
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 property_opts = [
     cfg.StrOpt('property_protection_file',

glance/common/rpc.py

@@ -29,9 +29,11 @@ from glance.common import client
 from glance.common import exception
 from glance.common import utils
 from glance.common import wsgi
+from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 
 rpc_opts = [

glance/common/scripts/image_import/main.py

@@ -30,10 +30,11 @@ from glance.openstack.common import lockutils
 import glance.openstack.common.log as logging
 
 
+LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW
-LOG = logging.getLogger(__name__)
 
 
 def run(t_id, context, task_repo, image_repo, image_factory):

glance/common/scripts/utils.py

@@ -29,8 +29,9 @@ from glance import i18n
 import glance.openstack.common.log as logging
 
 
-_LE = i18n._LE
 LOG = logging.getLogger(__name__)
+_ = i18n._
+_LE = i18n._LE
 
 
 def get_task(task_repo, task_id):

glance/common/store_utils.py

@@ -23,11 +23,11 @@ from glance import i18n
 import glance.openstack.common.log as logging
 from glance import scrubber
 
+LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LW = i18n._LW
 
-LOG = logging.getLogger(__name__)
-
 store_utils_opts = [
     cfg.BoolOpt('use_user_token', default=True,
                 help=_('Whether to pass through the user token when '

glance/common/swift_store_utils.py

@@ -21,8 +21,11 @@ except ImportError:
 from oslo.config import cfg
 
 from glance.common import exception
+from glance import i18n
 from glance.openstack.common import log as logging
 
+_ = i18n._
+
 swift_opts = [
     cfg.StrOpt('default_swift_reference',
                default="ref1",

glance/common/utils.py

@@ -46,11 +46,13 @@ import six
 from webob import exc
 
 from glance.common import exception
+from glance import i18n
 import glance.openstack.common.log as logging
 
 CONF = cfg.CONF
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 FEATURE_BLACKLIST = ['content-length', 'content-type', 'x-image-meta-size']
 

glance/common/wsgi.py

@@ -49,6 +49,7 @@ from glance import i18n
 import glance.openstack.common.log as logging
 from glance.openstack.common import processutils
 
+_ = i18n._
 
 bind_opts = [
     cfg.StrOpt('bind_host', default='0.0.0.0',

glance/db/__init__.py

@@ -26,6 +26,9 @@ from glance.common import exception
 from glance.common import location_strategy
 import glance.domain
 import glance.domain.proxy
+from glance import i18n
+
+_ = i18n._
 
 CONF = cfg.CONF
 CONF.import_opt('image_size_cap', 'glance.common.config')

glance/db/simple/api.py

@@ -27,6 +27,7 @@ import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LI = i18n._LI
 _LW = i18n._LW
 

glance/db/sqlalchemy/api.py

@@ -49,6 +49,7 @@ import glance.openstack.common.log as os_logging
 BASE = models.BASE
 sa_logger = None
 LOG = os_logging.getLogger(__name__)
+_ = i18n._
 _LI = i18n._LI
 _LW = i18n._LW
 

glance/db/sqlalchemy/metadata.py

@@ -35,6 +35,7 @@ from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LW = i18n._LW
 _LI = i18n._LI

glance/db/sqlalchemy/metadef_api/namespace.py

@@ -25,6 +25,7 @@ from glance import i18n
 import glance.openstack.common.log as os_logging
 
 LOG = os_logging.getLogger(__name__)
+_ = i18n._
 _LW = i18n._LW
 
 

glance/db/sqlalchemy/metadef_api/object.py

@@ -25,6 +25,7 @@ from glance import i18n
 import glance.openstack.common.log as os_logging
 
 LOG = os_logging.getLogger(__name__)
+_ = i18n._
 _LW = i18n._LW
 
 

glance/db/sqlalchemy/metadef_api/property.py

@@ -25,6 +25,7 @@ from glance import i18n
 import glance.openstack.common.log as os_logging
 
 LOG = os_logging.getLogger(__name__)
+_ = i18n._
 _LW = i18n._LW
 
 

glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py

@@ -22,6 +22,7 @@ from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 
 

glance/db/sqlalchemy/migrate_repo/versions/017_quote_encrypted_swift_credentials.py

@@ -41,6 +41,7 @@ from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/domain/__init__.py

@@ -28,6 +28,7 @@ from glance.common import exception
 from glance import i18n
 import glance.openstack.common.log as logging
 
+_ = i18n._
 _LE = i18n._LE
 LOG = logging.getLogger(__name__)
 CONF = cfg.CONF

glance/image_cache/__init__.py

@@ -30,6 +30,7 @@ from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/image_cache/client.py

@@ -19,6 +19,9 @@ from oslo.serialization import jsonutils as json
 
 from glance.common import client as base_client
 from glance.common import exception
+from glance import i18n
+
+_ = i18n._
 
 
 class CacheClient(base_client.BaseClient):

glance/image_cache/drivers/base.py

@@ -23,9 +23,11 @@ from oslo.config import cfg
 
 from glance.common import exception
 from glance.common import utils
+from glance import i18n
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 CONF = cfg.CONF
 

glance/image_cache/drivers/sqlite.py

@@ -35,6 +35,7 @@ from glance.image_cache.drivers import base
 import glance.openstack.common.log as logging
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/location.py

@@ -26,7 +26,7 @@ import glance.domain.proxy
 from glance import i18n
 import glance.openstack.common.log as logging
 
-
+_ = i18n._
 _LE = i18n._LE
 
 CONF = cfg.CONF

glance/notifier.py

@@ -24,8 +24,11 @@ import webob
 from glance.common import exception
 from glance.common import utils
 import glance.domain.proxy
+from glance import i18n
 import glance.openstack.common.log as logging
 
+_ = i18n._
+
 notifier_opts = [
     cfg.StrOpt('default_publisher_id', default="image.localhost",
                help='Default publisher_id for outgoing notifications.'),

glance/opts.py

@@ -35,7 +35,6 @@ import glance.common.wsgi
 import glance.image_cache
 import glance.image_cache.drivers.sqlite
 import glance.notifier
-from glance.openstack.common import gettextutils
 import glance.openstack.common.lockutils
 import glance.openstack.common.log
 import glance.registry
@@ -43,10 +42,6 @@ import glance.registry.client
 import glance.registry.client.v1.api
 import glance.scrubber
 
-# TODO(zhiyan): Remove translation from in-line
-# help message of option definition code.
-gettextutils.install('glance', lazy=False)
-
 
 _global_opt_lists = [
     glance.openstack.common.log.common_cli_opts,

glance/quota/__init__.py

@@ -29,6 +29,7 @@ import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LI = i18n._LI
 CONF = cfg.CONF
 CONF.import_opt('image_member_quota', 'glance.common.config')

glance/registry/__init__.py

@@ -19,6 +19,9 @@ Registry API
 
 from oslo.config import cfg
 
+from glance import i18n
+
+_ = i18n._
 
 registry_addr_opts = [
     cfg.StrOpt('registry_host', default='0.0.0.0',

glance/registry/api/v1/images.py

@@ -31,6 +31,7 @@ import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 _LW = i18n._LW

glance/registry/api/v1/members.py

@@ -24,6 +24,7 @@ import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LI = i18n._LI
 _LW = i18n._LW
 

glance/registry/api/v2/rpc.py

@@ -22,10 +22,12 @@ from oslo.config import cfg
 from glance.common import rpc
 from glance.common import wsgi
 import glance.db
+from glance import i18n
 import glance.openstack.common.log as logging
 
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 CONF = cfg.CONF
 

glance/registry/client/__init__.py

@@ -15,6 +15,10 @@
 
 from oslo.config import cfg
 
+from glance import i18n
+
+_ = i18n._
+
 registry_client_opts = [
     cfg.StrOpt('registry_client_protocol', default='http',
                help=_('The protocol to use for communication with the '

glance/registry/client/v1/api.py

@@ -23,10 +23,12 @@ from oslo.config import cfg
 from oslo.serialization import jsonutils
 
 from glance.common import exception
+from glance import i18n
 import glance.openstack.common.log as logging
 from glance.registry.client.v1 import client
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 registry_client_ctx_opts = [
     cfg.BoolOpt('send_identity_headers', default=False,

glance/registry/client/v2/api.py

@@ -22,10 +22,12 @@ import os
 from oslo.config import cfg
 
 from glance.common import exception
+from glance import i18n
 import glance.openstack.common.log as logging
 from glance.registry.client.v2 import client
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 
 CONF = cfg.CONF
 _registry_client = 'glance.registry.client'

glance/schema.py

@@ -18,6 +18,9 @@ import six
 
 from glance.common import exception
 from glance.common import utils
+from glance import i18n
+
+_ = i18n._
 
 
 class Schema(object):

glance/scrubber.py

@@ -34,6 +34,7 @@ import glance.registry.client.v1.api as registry
 
 LOG = logging.getLogger(__name__)
 
+_ = i18n._
 _LI = i18n._LI
 _LW = i18n._LW
 _LE = i18n._LE

glance/tests/functional/v2/test_metadef_resourcetypes.py

@@ -34,6 +34,7 @@ import glance.openstack.common.log as logging
 import glance.schema
 
 LOG = logging.getLogger(__name__)
+_ = i18n._
 _LE = i18n._LE
 _LI = i18n._LI
 

glance/tests/unit/test_migrations.py

@@ -48,7 +48,9 @@ from glance.db import migration
 from glance.db.sqlalchemy import migrate_repo
 from glance.db.sqlalchemy.migrate_repo.schema import from_migration_import
 from glance.db.sqlalchemy import models
+from glance import i18n
 
+_ = i18n._
 
 CONF = cfg.CONF
 CONF.import_opt('metadata_encryption_key', 'glance.common.config')

glance/tests/unit/v2/test_registry_client.py

@@ -31,12 +31,14 @@ from glance.common import config
 from glance.common import exception
 from glance import context
 from glance.db.sqlalchemy import api as db_api
+from glance import i18n
 from glance.registry.api import v2 as rserver
 import glance.registry.client.v2.api as rapi
 from glance.registry.client.v2.api import client as rclient
 from glance.tests.unit import base
 from glance.tests import utils as test_utils
 
+_ = i18n._
 
 _gen_uuid = lambda: str(uuid.uuid4())
 

tox.ini

@@ -50,7 +50,6 @@ commands = python setup.py build_sphinx
 # H405  multi line docstring summary not separated with an empty line
 # H904  Wrap long lines in parentheses instead of a backslash
 ignore = E711,E712,H302,H402,H404,H405,H904
-builtins = _
 exclude = .venv,.git,.tox,dist,doc,etc,*glance/locale*,*openstack/common*,*lib/python*,*egg,build
 
 [hacking]