openstack/glance
Code Issues Proposed changes

Make it clear that the checksum is an MD5 checksum in docs.

Browse Source
This commit is contained in:
jaypipes@gmail.com 2011-03-08 11:40:35 -05:00
parent af11621170
commit b2ec714d12
3 changed files with 5 additions and 3 deletions
doc/source
glanceapi.rst
glance
server.py
tests
stubs.py

5
doc/source/glanceapi.rst

@ -90,6 +90,8 @@ JSON-encoded mapping in the following format::
The `properties` field is a mapping of free-form key/value pairs that
have been saved with the image metadata
The `checksum` field is an MD5 checksum of the image file data
Requesting Detailed Metadata on a Specific Image
------------------------------------------------
@ -295,7 +297,8 @@ The list of metadata headers that Glance accepts are listed below.
* ``x-image-meta-checksum``
This header is optional.
This header is optional. When present it shall be the expected **MD5**
checksum of the image file data.
When present, Glance will verify the checksum generated from the backend
store when storing your image against this value and return a

2
glance/server.py

@ -260,7 +260,7 @@ class Controller(wsgi.Controller):
logger.debug("Updating image %(image_id)s data. "
"Checksum set to %(checksum)s, size set "
"to %(size)d" % locals())
m = registry.update_image_metadata(self.options, image_id,
registry.update_image_metadata(self.options, image_id,
{'checksum': checksum,
'size': size})

1
tests/stubs.py

@ -220,7 +220,6 @@ def stub_out_registry_and_store_server(stubs):
'registry_host': '0.0.0.0',
'registry_port': '9191',
'default_store': 'file',
'checksum': True,
'filesystem_store_datadir': FAKE_FILESYSTEM_ROOTDIR}
res = self.req.get_response(server.API(options))