Merge "Fix nits from commit that introduces cursive"

This commit is contained in:
Jenkins 2016-09-08 15:08:23 +00:00 committed by Gerrit Code Review
commit b50cd90f65
3 changed files with 25 additions and 18 deletions

View File

@ -421,8 +421,9 @@ class ImageProxy(glance.domain.proxy.Image):
key_type = extra_props[signature_utils.KEY_TYPE]
cert_uuid = extra_props[signature_utils.CERT_UUID]
verifier = signature_utils.get_verifier(
self.context, cert_uuid, hash_method,
img_signature, key_type
context=self.context, cert_uuid=cert_uuid,
hash_method=hash_method, img_signature=img_signature,
key_type=key_type
)
else:
verifier = None

View File

@ -1,16 +0,0 @@
---
prelude: >
Glance and Nova contain nearly identical digital signature modules. In
order to better maintain and evolve this code and to eliminate
the possibility that the modules diverge, we propose removing this code
and instead using the new cursive library. Please read the other section
for more details.
other:
- The cursive library is an OpenStack project which implements
OpenStack-specific verification of digital signatures. In Newton, the
majority of the signature verification code was removed from Glance.
Cursive has been added to Glance as a dependency and will be installed by
default. Glance uses the Cursive library's functionality to verify digital
signatures. To familiarize yourself with this new dependency and see the
list of transitive dependencies visit
https://github.com/openstack/cursive

View File

@ -0,0 +1,22 @@
---
other:
- |
Glance and Nova contain nearly identical digital
signature modules. In order to better maintain and
evolve this code and to eliminate the possibility that
the modules diverge, we have replaced the digital
signature module in Glance with the new ``cursive``
library.
* The ``cursive`` library is an OpenStack project which
implements OpenStack-specific verification of digital
signatures.
* In Newton, the majority of the signature verification
code was removed from Glance. ``cursive`` has been
added to Glance as a dependency and will be installed
by default.
* Glance uses the ``cursive`` library's functionality to
verify digital signatures. To familiarize yourself
with this new dependency and see the list of
transitive dependencies visit
http://git.openstack.org/cgit/openstack/cursive