openstack/glance
Code Issues Proposed changes

Update "Disallowed minor code changes" doc

Browse Source 
Update contributor docs to reflect the discussion of oslo library
usage at the 10 January 2019 Glance weekly meeting.

Change-Id: Ibb75ce0cbc2b906838a5149dc75bfb27383178a7
This commit is contained in:
Brian Rosmaita 2019-01-10 11:46:46 -05:00
parent fb2c2e7de1
commit cf2b3f25aa
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/source/contributor/minor-code-changes.rst
View File

@ -94,3 +94,15 @@ Python 3. While the deprecation is real, Glance uses oslo_log that provides
alias warn and solves the issue in single place for all projects using it.
These changes are not accepted due to the huge amount of refactoring they
cause for no reason.
Gratuitious use of oslo libraries
---------------------------------
We are big fans of the oslo libraries and all the hard work the Oslo team does
to keep common code reusable and easily consumable. But that doesn't mean that
it's a bug if Glance isn't using an oslo library everywhere you could possibly
use one. We are all for using oslo if it provides any level of benefit for us
and makes sense, but please let's not have these bugs/patches of "Let's use
oslo because it exists".