openstack/glance
Code Issues Proposed changes

Typo fix in glance: existant => existent

Browse Source 
Impact:
* Test function names
* Test strings and comments
* Comment in glance/registry/api/v1/members.py

Change-Id: I8cec84c4934c08905e7f8758dec3622a5261b153
This commit is contained in:
Rongze Zhu 2012-08-23 03:31:36 +00:00
parent 66c10d434a
commit dc6ef98a4b
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glance/registry/api/v1/members.py
View File

@ -156,7 +156,7 @@ class Controller(object):
self.db_api.image_member_delete(req.context, memb, self.db_api.image_member_delete(req.context, memb,
session=session) session=session)
# Now add the non-existant ones # Now add the non-existent ones
for memb in add: for memb in add:
self.db_api.image_member_create(req.context, memb, session=session) self.db_api.image_member_create(req.context, memb, session=session)

4
glance/tests/unit/test_clients.py
View File

@ -1163,7 +1163,7 @@ class TestRegistryClient(base.IsolatedUnitTest):
self.assertEquals(num_members, 0) self.assertEquals(num_members, 0)
def test_get_image_members_not_existing(self): def test_get_image_members_not_existing(self):
"""Tests getting non-existant image members""" """Tests getting non-existent image members"""
self.assertRaises(exception.NotFound, self.assertRaises(exception.NotFound,
self.client.get_image_members, self.client.get_image_members,
_gen_uuid()) _gen_uuid())
@ -2099,7 +2099,7 @@ class TestClient(base.IsolatedUnitTest):
self.assertEquals(num_members, 0) self.assertEquals(num_members, 0)
def test_get_image_members_not_existing(self): def test_get_image_members_not_existing(self):
"""Tests getting non-existant image members""" """Tests getting non-existent image members"""
self.assertRaises(exception.NotFound, self.assertRaises(exception.NotFound,
self.client.get_image_members, self.client.get_image_members,
_gen_uuid()) _gen_uuid())

4
glance/tests/unit/v2/test_image_data_resource.py
View File

@ -47,7 +47,7 @@ class TestImagesController(base.StoreClearingUnitTest):
self.assertRaises(webob.exc.HTTPNotFound, self.controller.download, self.assertRaises(webob.exc.HTTPNotFound, self.controller.download,
request, unit_test_utils.UUID2) request, unit_test_utils.UUID2)
def test_download_non_existant_image(self): def test_download_non_existent_image(self):
request = unit_test_utils.get_fake_request() request = unit_test_utils.get_fake_request()
self.assertRaises(webob.exc.HTTPNotFound, self.controller.download, self.assertRaises(webob.exc.HTTPNotFound, self.controller.download,
request, utils.generate_uuid()) request, utils.generate_uuid())
@ -60,7 +60,7 @@ class TestImagesController(base.StoreClearingUnitTest):
self.assertEqual(4, output['meta']['size']) self.assertEqual(4, output['meta']['size'])
self.assertEqual('YYYY', output['data']) self.assertEqual('YYYY', output['data'])
def test_upload_non_existant_image(self): def test_upload_non_existent_image(self):
request = unit_test_utils.get_fake_request() request = unit_test_utils.get_fake_request()
self.assertRaises(webob.exc.HTTPNotFound, self.controller.upload, self.assertRaises(webob.exc.HTTPNotFound, self.controller.upload,
request, utils.generate_uuid(), 'YYYY', 4) request, utils.generate_uuid(), 'YYYY', 4)

8
glance/tests/unit/v2/test_images_resource.py
View File

@ -184,7 +184,7 @@ class TestImagesController(test_utils.BaseTestCase):
expected = set([UUID1, UUID2, UUID3]) expected = set([UUID1, UUID2, UUID3])
self.assertEqual(actual, expected) self.assertEqual(actual, expected)
def test_index_with_nonexistant_name_filter(self): def test_index_with_nonexistent_name_filter(self):
request = unit_test_utils.get_fake_request('/images?name=%s' % 'blah') request = unit_test_utils.get_fake_request('/images?name=%s' % 'blah')
images = self.controller.index(request, images = self.controller.index(request,
filters={'name': 'blah'})['images'] filters={'name': 'blah'})['images']
@ -294,7 +294,7 @@ class TestImagesController(test_utils.BaseTestCase):
self.assertEqual(UUID2, output['id']) self.assertEqual(UUID2, output['id'])
self.assertEqual('2', output['name']) self.assertEqual('2', output['name'])
def test_show_non_existant(self): def test_show_non_existent(self):
request = unit_test_utils.get_fake_request() request = unit_test_utils.get_fake_request()
image_id = utils.generate_uuid() image_id = utils.generate_uuid()
self.assertRaises(webob.exc.HTTPNotFound, self.assertRaises(webob.exc.HTTPNotFound,
@ -329,7 +329,7 @@ class TestImagesController(test_utils.BaseTestCase):
self.assertEqual('image-2', output['name']) self.assertEqual('image-2', output['name'])
self.assertNotEqual(output['created_at'], output['updated_at']) self.assertNotEqual(output['created_at'], output['updated_at'])
def test_update_non_existant(self): def test_update_non_existent(self):
request = unit_test_utils.get_fake_request() request = unit_test_utils.get_fake_request()
image = {'name': 'image-2'} image = {'name': 'image-2'}
self.assertRaises(webob.exc.HTTPNotFound, self.controller.update, self.assertRaises(webob.exc.HTTPNotFound, self.controller.update,
@ -348,7 +348,7 @@ class TestImagesController(test_utils.BaseTestCase):
except Exception as e: except Exception as e:
self.fail("Delete raised exception: %s" % e) self.fail("Delete raised exception: %s" % e)
def test_delete_non_existant(self): def test_delete_non_existent(self):
request = unit_test_utils.get_fake_request() request = unit_test_utils.get_fake_request()
self.assertRaises(webob.exc.HTTPNotFound, self.controller.delete, self.assertRaises(webob.exc.HTTPNotFound, self.controller.delete,
request, utils.generate_uuid()) request, utils.generate_uuid())