openstack/glance
Code Issues Proposed changes

Enable gating on F811 (duplicate function definition)

Browse Source 
Change-Id: Ifbf233ccbb7cc012d5dae50f9b303cfca592788d
This commit is contained in:
Dirk Mueller 2013-12-11 23:54:38 +01:00
parent 41a4e4d72c
commit f0dad5c5d5
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glance/tests/utils.py
View File

@ -469,8 +469,8 @@ class RegistryAPIMixIn(object):
def assertEqualImages(self, res, uuids, key='images', unjsonify=True):
images = json.loads(res.body)[key] if unjsonify else res
self.assertEqual(len(images), len(uuids))
for i, uuid in enumerate(uuids):
self.assertEqual(images[i]['id'], uuid)
for i, value in enumerate(uuids):
self.assertEqual(images[i]['id'], value)
class FakeAuthMiddleware(wsgi.Middleware):

3
tox.ini
View File

@ -30,13 +30,12 @@ commands = {posargs}
# TODO(dmllr): Analyze or fix the warnings blacklisted below
# E711 comparison to None should be 'if cond is not None:'
# E712 comparison to True should be 'if cond is True:' or 'if cond:'
# F811 redefinition of function
# F821 undefined name 'name'
# F841 local variable 'name' assigned but never used
# H202 assertRaises Exception too broad
# H402 one line docstring needs punctuation.
# H404 multi line docstring should start with a summary
# H703 multiple positional placeholders
ignore = E711,E712,F811,F821,F841,H202,H402,H404,H703
ignore = E711,E712,F821,F841,H202,H402,H404,H703
builtins = _
exclude = .venv,.git,.tox,dist,doc,etc,*glance/locale*,*openstack/common*,*lib/python*,*egg,build