openstack/glance
Code Issues Proposed changes

emit warning while running flake8 without virtual env

Browse Source 
run_tests.sh -N -p

it will call the flake8 installed on your host to detect PEP8, and
the flake8 plugin "OpenStack hacking" may not installed on your
host, so this command may not detect the OpenStack Style Commandment
supplied by hacking(e.g H202).

run_tests.sh -p
it will call the flake8 from virtual env, flake8 plugin "OpenStack
hacking" installed in virtual env will be triggered.

The result from "run_tests.sh -p" should be trusted, and jenkins uses
virtual env to run flake8 too.

When "-N" is enabled, emit warning to stderr to remind user.

Bug #1215396

Change-Id: Iac6be532b7b9bb911b745712712d1be363e8ff01
This commit is contained in:
Kui Shi 2013-08-28 07:03:52 +08:00
parent 6735fbb3f2
commit fe897c0b79
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
run_tests.sh
View File

@ -68,6 +68,10 @@ function run_tests {
function run_flake8 {
echo "Running flake8 ..."
if [ $never_venv -eq 1 ]; then
echo "**WARNING**:" >&2
echo "Running flake8 without virtual env may miss OpenStack HACKING detection" >&2
fi
${wrapper} flake8
}