15 Commits

Author SHA1 Message Date
Eoghan Glynn
593e8c2fa7 Add --await-child option to glance-control.
Fixes bug 817032

Previously an immediate non-zero exit status from service
launch was not reflected in the exit status returned from
glance-control.

Now the parent glance-control process configurably waits for
the child to exit ungracefully and if this occurs, it inherits
the non-zero status code from the child.

Change-Id: Ibbe92a5bf40d095951a572d78ae07026d8a9313d
2012-02-02 17:40:32 +00:00
Mark McLoughlin
3b2ef8e29e glance-control need not locate a server's config file (lp#919520)
Before converting to cfg, glance-control would use find_config_file() to
locate the servers config file if the user did not explicitly specify
it.

With the change over to cfg, we screwed that code up. However, we should
instead just allow the server to locate its own config file rather than
trying to guess what it will use.

Change-Id: I422839ae4c684ff2de3a0a96dd54c6b74ce6df97
2012-01-23 08:32:52 +00:00
Yaguang Tang
2528e569d0 fix bug 911681
need not to use optparse in  bin/glance-control.

Change-Id: I3096a39fd0c26f9fa5243f7cc2bd25dd8d5235ea
2012-01-05 00:41:24 +08:00
Mark McLoughlin
57c4e9b6c6 Convert glance to use the new cfg module
The changes here are substantial and widespread, but in summary:

  - We use cfg to parse the CLI and config files, rather than optparse
    and PasteDeploy

  - A schema is defined for all configuration options close to the code
    which uses the option

  - 2 ConfigOpts sub-classes are added to config.py basically just
    defining how to find config files; this means we can now use e.g.
    glance.conf for base config values which glance-api.conf can
    override

  - load_paste_app() is changed to load the paste app from the last
    config file in the stack and pass the app the ConfigOpts instance

  - The generic app and filter factories in wsgi.py are modified to
    pass a ConfigOpts instance to the apps and filters

  - A ConfigOpts subclass is added for the unit tests which writes out
    config values to a temporary config file and uses cfg to parse that

I've tried to keep the switch as unobtrusive as possible leaving further
cleanups for later e.g.

  - Moving PasteDeploy config out of the config files - I think it would
    be good to aim for having users modify the PasteDeploy config files
    only in fairly rare circumstances. To achieve this, we might define
    a number of common pipelines in the PasteDeploy config and allow
    the user to choose between those pipelines in the glance config.

  - We should add help strings to all the opts, even just for the sake
    of documenting them

  - We should move a bunch of the options into groups - e.g. all the
    rabbit options

  - We no longer rely on config files for default values, so the default
    config files could contain nothing but comments - i.e. explaining
    each option and showing what the default for it is - making it
    obvious where a user has explicitly set a value

There are a couple of behavioural changes which I don't think are
signifcant but are worth mentioning:

  - We used to support passing a config file as a positional argument
    but don't anymore; AFAICT, it was only used by glance-manage when
    launching servers and I've changed that to pass --config-file

  - log_opt_values() doesn't log unknown opts, so won't log any values
    for opts which get registered at runtime later

Change-Id: Iafa998a2a8d860f1ad57e2cd2afee69686ed58ba
2011-12-08 22:32:52 +00:00
Mark McLoughlin
1f979ca757 Allow glance-cache-* find their config files
By default, glance-cache-cleaner looks for glance-cleaner.conf but
its actual config file is glance-cache.conf.

Change the find_config_file() argument to conf_name and make it an
optional argument to load_paste_app(). This allows us to specify
a different config file for the glance apps than their app name.

find_config_file() is also changed to raise an exception if no
config file is found.

Change-Id: Iec71218f5b2f0a7f057ea02f4549bd743892cc65
2011-11-09 22:51:20 +00:00
Justin Shepherd
8a33e24311 Addresses glance/+spec/i18n
Added gettext.install to glance endpoints, setup.py, and run_tests.py. Wrapped all exceptions in common/exception.py with gettext.

Included fix for bug lp:823676.

Change-Id: Ied4381e1676227afea857acd01f4754e6a181106
2011-08-10 09:09:56 -05:00
Justin Shepherd
0c08a0404f Replaced occurances of |str(e)| with |"%s" % e|.
Except in bin/glance, becaue |unicode(e).split('\n')| is prettier than |("%s" % e).split('\n')|
2011-07-29 22:26:00 -05:00
Jason Kölker
4eaf79dc29 add glance-scrubber to glance-control 2011-06-13 12:52:21 -05:00
jaypipes@gmail.com
1359d6e2cc Fix up find_config_file() to accept an app_name arg. Update all documentation referencing config files. 2011-05-09 14:55:46 -04:00
Ewan Mellor
4791da25ba Bug #737979: glance-control uses fixed path to Python interpreter, breaking virtualenv
Change #!/usr/bin/python to #!/usr/bin/env python.
2011-03-19 03:03:46 +00:00
jaypipes@gmail.com
bb5f1229ef Use Nova's path trick in all bins... 2011-02-21 17:11:27 -05:00
jaypipes@gmail.com
45618b7398 Add path to glance-control 2011-02-21 16:57:00 -05:00
jaypipes@gmail.com
9846d3e69d Adds --pid-file option to bin/glance-control 2011-02-16 02:43:11 -05:00
jaypipes@gmail.com
714013e07a Remove get_config_file_options() from glance-control 2011-02-09 16:59:39 -05:00
jaypipes@gmail.com
66f4b78234 Adds bin/glance-control program server daemonization wrapper
program based on Swift's swift-init script.

Adds a crap-ton of documentation on installing Glance and
controlling Glance's server programs.

This was necessary since when glance.common.server was removed
from Glance and paste.deploy used, we lost the ability to control
server daemonization with CLI options. This adds back some of that
functionality while still using paste.deploy like Swift does.
2011-02-04 18:59:52 -05:00