Two things were happening that this patch corrects:
a) If adding an image fails, the glance add output says that
adding the image failed, however, doing a glance index would
show the image. This was because the call to get all public
images was not correctly filtering the result for 'active'
status images. The image failing to be added causes the image
status to be 'killed', and so killed images should not appear
in the output of glance index or glance detail.
b) glance show <ID> was not showing the status of the image, so
it was not clear that the image, while not added successfully,
was still in the registry, but in a 'killed' status.
I added a note to the output of the failed add command that the
Glance registry may still have an image record, but the status
would likely be in the 'killed' state.
Added a functional test case that verified the behaviour in the bug
and verified the fix, once coded.
197e862bfe