931809c037
Change-Id: Ibca3884e1ea3d0fb170bcc9e70a176d144ee24cc Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
104 lines
4.1 KiB
Python
104 lines
4.1 KiB
Python
# Copyright 2014 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from glance.hacking import checks
|
|
from glance.tests import utils
|
|
|
|
|
|
class HackingTestCase(utils.BaseTestCase):
|
|
def test_assert_true_instance(self):
|
|
self.assertEqual(1, len(list(checks.assert_true_instance(
|
|
"self.assertTrue(isinstance(e, "
|
|
"exception.BuildAbortException))"))))
|
|
|
|
self.assertEqual(
|
|
0, len(list(checks.assert_true_instance("self.assertTrue()"))))
|
|
|
|
def test_assert_equal_type(self):
|
|
self.assertEqual(1, len(list(checks.assert_equal_type(
|
|
"self.assertEqual(type(also['QuicAssist']), list)"))))
|
|
|
|
self.assertEqual(
|
|
0, len(list(checks.assert_equal_type("self.assertTrue()"))))
|
|
|
|
def test_assert_equal_none(self):
|
|
self.assertEqual(1, len(list(checks.assert_equal_none(
|
|
"self.assertEqual(A, None)"))))
|
|
|
|
self.assertEqual(1, len(list(checks.assert_equal_none(
|
|
"self.assertEqual(None, A)"))))
|
|
|
|
self.assertEqual(
|
|
0, len(list(checks.assert_equal_none("self.assertIsNone()"))))
|
|
|
|
def test_no_translate_debug_logs(self):
|
|
self.assertEqual(1, len(list(checks.no_translate_debug_logs(
|
|
"LOG.debug(_('foo'))", "glance/store/foo.py"))))
|
|
|
|
self.assertEqual(0, len(list(checks.no_translate_debug_logs(
|
|
"LOG.debug('foo')", "glance/store/foo.py"))))
|
|
|
|
self.assertEqual(0, len(list(checks.no_translate_debug_logs(
|
|
"LOG.info(_('foo'))", "glance/store/foo.py"))))
|
|
|
|
def test_no_contextlib_nested(self):
|
|
self.assertEqual(1, len(list(checks.check_no_contextlib_nested(
|
|
"with contextlib.nested("))))
|
|
|
|
self.assertEqual(1, len(list(checks.check_no_contextlib_nested(
|
|
"with nested("))))
|
|
|
|
self.assertEqual(0, len(list(checks.check_no_contextlib_nested(
|
|
"with foo as bar"))))
|
|
|
|
def test_dict_constructor_with_list_copy(self):
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" dict([(i, connect_info[i])"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" attrs = dict([(k, _from_json(v))"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" type_names = dict((value, key) for key, value in"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" dict((value, key) for key, value in"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
"foo(param=dict((k, v) for k, v in bar.items()))"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" dict([[i,i] for i in range(3)])"))))
|
|
|
|
self.assertEqual(1, len(list(checks.dict_constructor_with_list_copy(
|
|
" dd = dict([i,i] for i in range(3))"))))
|
|
|
|
self.assertEqual(0, len(list(checks.dict_constructor_with_list_copy(
|
|
" create_kwargs = dict(snapshot=snapshot,"))))
|
|
|
|
self.assertEqual(0, len(list(checks.dict_constructor_with_list_copy(
|
|
" self._render_dict(xml, data_el, data.__dict__)"))))
|
|
|
|
def test_no_log_warn(self):
|
|
code = """
|
|
LOG.warn("LOG.warn is deprecated")
|
|
"""
|
|
errors = [(1, 0, 'G330')]
|
|
self._assert_has_errors(code, checks.no_log_warn,
|
|
expected_errors=errors)
|
|
code = """
|
|
LOG.warning("LOG.warn is deprecated")
|
|
"""
|
|
self._assert_has_no_errors(code, checks.no_log_warn)
|