8a8e5bf56c
There are several places in the source code where HTTP response codes are used as numeric values. These values are used from six.moves and the numeric values are replaced by constants. All of the used status codes were replaced with symbolic constants from six.moves.http_client. More about six.moves.http_client can be found at [2], under the table "Supported renames:". Also, this change improves code readibility. This patchset does not extract numeric values from the code itself, but it can be found at [1]. [1]: Ib9e26dcea927e96e65c626c18421621d3a29a64d [2]: https://pythonhosted.org/six/#module-six.moves Change-Id: Idfc7b043552f428f01ac3e47b270ee0639a8f5bc Closes-Bug: #1520159
139 lines
4.4 KiB
Python
139 lines
4.4 KiB
Python
# Copyright 2011 OpenStack Foundation
|
|
# Copyright 2012 Red Hat, Inc
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""Functional test asserting strongly typed exceptions from glance client"""
|
|
|
|
import eventlet.patcher
|
|
import httplib2
|
|
from six.moves import http_client
|
|
import webob.dec
|
|
import webob.exc
|
|
|
|
from glance.common import client
|
|
from glance.common import exception
|
|
from glance.common import wsgi
|
|
from glance.tests import functional
|
|
from glance.tests import utils
|
|
|
|
|
|
eventlet.patcher.monkey_patch(socket=True)
|
|
|
|
|
|
class ExceptionTestApp(object):
|
|
"""
|
|
Test WSGI application which can respond with multiple kinds of HTTP
|
|
status codes
|
|
"""
|
|
|
|
@webob.dec.wsgify
|
|
def __call__(self, request):
|
|
path = request.path_qs
|
|
|
|
if path == "/rate-limit":
|
|
request.response = webob.exc.HTTPRequestEntityTooLarge()
|
|
|
|
elif path == "/rate-limit-retry":
|
|
request.response.retry_after = 10
|
|
request.response.status = http_client.REQUEST_ENTITY_TOO_LARGE
|
|
|
|
elif path == "/service-unavailable":
|
|
request.response = webob.exc.HTTPServiceUnavailable()
|
|
|
|
elif path == "/service-unavailable-retry":
|
|
request.response.retry_after = 10
|
|
request.response.status = http_client.SERVICE_UNAVAILABLE
|
|
|
|
elif path == "/expectation-failed":
|
|
request.response = webob.exc.HTTPExpectationFailed()
|
|
|
|
elif path == "/server-error":
|
|
request.response = webob.exc.HTTPServerError()
|
|
|
|
elif path == "/server-traceback":
|
|
raise exception.ServerError()
|
|
|
|
|
|
class TestClientExceptions(functional.FunctionalTest):
|
|
|
|
def setUp(self):
|
|
super(TestClientExceptions, self).setUp()
|
|
self.port = utils.get_unused_port()
|
|
server = wsgi.Server()
|
|
self.config(bind_host='127.0.0.1')
|
|
self.config(workers=0)
|
|
server.start(ExceptionTestApp(), self.port)
|
|
self.client = client.BaseClient("127.0.0.1", self.port)
|
|
|
|
def _do_test_exception(self, path, exc_type):
|
|
try:
|
|
self.client.do_request("GET", path)
|
|
self.fail('expected %s' % exc_type)
|
|
except exc_type as e:
|
|
if 'retry' in path:
|
|
self.assertEqual(10, e.retry_after)
|
|
|
|
def test_rate_limited(self):
|
|
"""
|
|
Test rate limited response
|
|
"""
|
|
self._do_test_exception('/rate-limit', exception.LimitExceeded)
|
|
|
|
def test_rate_limited_retry(self):
|
|
"""
|
|
Test rate limited response with retry
|
|
"""
|
|
self._do_test_exception('/rate-limit-retry', exception.LimitExceeded)
|
|
|
|
def test_service_unavailable(self):
|
|
"""
|
|
Test service unavailable response
|
|
"""
|
|
self._do_test_exception('/service-unavailable',
|
|
exception.ServiceUnavailable)
|
|
|
|
def test_service_unavailable_retry(self):
|
|
"""
|
|
Test service unavailable response with retry
|
|
"""
|
|
self._do_test_exception('/service-unavailable-retry',
|
|
exception.ServiceUnavailable)
|
|
|
|
def test_expectation_failed(self):
|
|
"""
|
|
Test expectation failed response
|
|
"""
|
|
self._do_test_exception('/expectation-failed',
|
|
exception.UnexpectedStatus)
|
|
|
|
def test_server_error(self):
|
|
"""
|
|
Test server error response
|
|
"""
|
|
self._do_test_exception('/server-error',
|
|
exception.ServerError)
|
|
|
|
def test_server_traceback(self):
|
|
"""
|
|
Verify that the wsgi server does not return tracebacks to the client on
|
|
500 errors (bug 1192132)
|
|
"""
|
|
http = httplib2.Http()
|
|
path = ('http://%s:%d/server-traceback' %
|
|
('127.0.0.1', self.port))
|
|
response, content = http.request(path, 'GET')
|
|
self.assertNotIn(b'ServerError', content)
|
|
self.assertEqual(http_client.INTERNAL_SERVER_ERROR, response.status)
|