openstack/glance_store
Code Issues Proposed changes

Use statvfs instead of df to get available space

Browse Source 
We should use Python's standard library if possible.

Change-Id: I923fe11aa7ffddef6f59970f889d3e7e58f4af68
Closes-Bug: 1386060
This commit is contained in:
Jian Wen 2014-10-27 15:57:41 +08:00
parent 6d4f6aa220
commit 16295ae977
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
glance_store/_drivers/filesystem.py
View File

@ -36,7 +36,6 @@ import glance_store.driver
from glance_store import exceptions
from glance_store import i18n
import glance_store.location
from glance_store.openstack.common import processutils
LOG = logging.getLogger(__name__)
@ -428,10 +427,8 @@ class Store(glance_store.driver.Store):
"""
#Calculate total available space
df = processutils.execute("df", "-k",
mount_point)[0].strip("'\n'")
total_available_space = int(df.split('\n')[1].split()[3]) * units.Ki
stvfs_result = os.statvfs(mount_point)
total_available_space = stvfs_result.f_bavail * stvfs_result.f_bsize
return max(0, total_available_space)
def _find_best_datadir(self, image_size):