Update patch set 2

Patch Set 2: Code-Review+1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 27615 <27615@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, c9e1328991cbebb950c30c65b542151140c9f4bb

127410cd811a58f77d255047ba0b245a30faa399

@@ -33,6 +33,46 @@
       "message": "Thank you!",
       "revId": "127410cd811a58f77d255047ba0b245a30faa399",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "26b65a02_e90ff2ef",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 27615
+      },
+      "writtenOn": "2023-05-23T08:56:34Z",
+      "side": 1,
+      "message": "Explanation inline of what we are doing here. LGTM.",
+      "revId": "127410cd811a58f77d255047ba0b245a30faa399",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "4f119023_2de24d18",
+        "filename": "glance_store/_drivers/rbd.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 296,
+      "author": {
+        "id": 27615
+      },
+      "writtenOn": "2023-05-23T08:56:34Z",
+      "side": 1,
+      "message": "eventletutils is_monkey_patched[1] calls eventlet\u0027s is_monkey_patched[2] to check if the module is already patched.\nSince monkeypatching in glance, patches everything[3] and \u0027thread\u0027 patches thread and threading modules[4], we should be good here.\n\nTo summarize, we run librbd calls in native threads when threading is monkey patched else we are already running everything in native threads.\n\n[1] https://github.com/openstack/oslo.utils/blob/439f39bdbfae5fc3e547c4be0c2b08c8f1b4922a/oslo_utils/eventletutils.py#L142\n[2] https://github.com/eventlet/eventlet/blob/dd2f0ea32d6b6d064be52fe8e27fca275985cdc4/eventlet/patcher.py#L372-L373\n[3] https://github.com/openstack/glance/blob/428295969836a2a0bad0ae0593ea1a890e155898/glance/cmd/api.py#L40\n[4] https://github.com/eventlet/eventlet/blob/dd2f0ea32d6b6d064be52fe8e27fca275985cdc4/eventlet/patcher.py#L238",
+      "range": {
+        "startLine": 296,
+        "startChar": 25,
+        "endLine": 296,
+        "endChar": 42
+      },
+      "revId": "127410cd811a58f77d255047ba0b245a30faa399",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }