openstack
/
glance_store
Code Issues Proposed changes

Disable propagating BadStoreConfiguration 

Commit I1d4f95cba47d21f1eb7e580314d01ac8d3481586 propergates
BadStoreConfiguration to the consumer of glance_store. This breaks
backwards compatibility for existing glance installations, however. This
patch disables it for the time being.

Change-Id: I46e1e38bf0b3ba9f78b4e553178b49bee929e0fd
This commit is contained in:
Louis Taylor 2015-05-14 11:50:03 +01:00
parent 56c9486800
commit 752f9cabd2
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glance_store/backend.py
View File

@ -183,7 +183,7 @@ def create_stores(conf=CONF):
for (store_entry, store_instance) in _load_stores(conf):
try:
schemes = store_instance.get_schemes()
store_instance.configure(re_raise_bsc=True)
store_instance.configure(re_raise_bsc=False)
except NotImplementedError:
continue
if not schemes:

6
tests/unit/test_store_base.py
View File

@ -26,12 +26,6 @@ class TestStoreBase(base.StoreBaseTest):
super(TestStoreBase, self).setUp()
self.config(default_store='file', group='glance_store')
def test_raise_on_missing_driver_conf(self):
self.config(stores=['file'], group='glance_store')
self.assertRaises(store.BadStoreConfiguration,
store.create_stores,
self.conf)
@mock.patch.object(store.driver, 'LOG')
def test_configure_does_not_raise_on_missing_driver_conf(self, mock_log):
self.config(stores=['file'], group='glance_store')