openstack
/
glance_store
Code Issues Proposed changes

Clean imports in code 

In some part in the code we import objects. In the Openstack style guidelines
they recommend to import only modules. [1]: "Do not import objects, only modules".

[1] https://docs.openstack.org/hacking/0.10.3/

Change-Id: I46b543f91f14deb56be424b12ab038b46862e4f4
This commit is contained in:
Nguyen Hung Phuong 2018-02-21 17:48:46 +07:00
parent 5585eb388c
commit 90911fe855
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
glance_store/tests/functional/base.py
View File

@ -13,7 +13,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from io import BytesIO
import io
from os import environ
import glance_store
@ -75,19 +75,19 @@ class Base(testtools.TestCase):
class BaseFunctionalTests(Base):
def test_add(self):
image_file = BytesIO(IMAGE_BITS)
image_file = io.BytesIO(IMAGE_BITS)
loc, written, _, _ = self.store.add(UUID1, image_file, len(IMAGE_BITS))
self.assertEqual(len(IMAGE_BITS), written)
def test_delete(self):
image_file = BytesIO(IMAGE_BITS)
image_file = io.BytesIO(IMAGE_BITS)
loc, written, _, _ = self.store.add(UUID2, image_file, len(IMAGE_BITS))
location = glance_store.location.get_location_from_uri(loc)
self.store.delete(location)
def test_get_size(self):
image_file = BytesIO(IMAGE_BITS)
image_file = io.BytesIO(IMAGE_BITS)
loc, written, _, _ = self.store.add(UUID3, image_file, len(IMAGE_BITS))
location = glance_store.location.get_location_from_uri(loc)
@ -95,7 +95,7 @@ class BaseFunctionalTests(Base):
self.assertEqual(len(IMAGE_BITS), size)
def test_get(self):
image_file = BytesIO(IMAGE_BITS)
image_file = io.BytesIO(IMAGE_BITS)
loc, written, _, _ = self.store.add(UUID3, image_file, len(IMAGE_BITS))
location = glance_store.location.get_location_from_uri(loc)