openstack/glance_store
Code Issues Proposed changes

An unit test passes because is launched as non-root user

Browse Source 
This change fixes the issue by setting filesystem_store_datadir
and filesystem_store_datadirs to None (missing values).

Closes-Bug: 1657710
Change-Id: Ida5bee9682e24befd63bd2b4b2107ee84eac1a1b
This commit is contained in:
Adam Kijak 2017-01-19 11:44:28 +00:00
parent 7cb7d262ce
commit f614b345be
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
glance_store/tests/unit/test_store_base.py
View File

@ -29,6 +29,12 @@ class TestStoreBase(base.StoreBaseTest):
@mock.patch.object(store.driver, 'LOG')
def test_configure_does_not_raise_on_missing_driver_conf(self, mock_log):
self.config(stores=['file'], group='glance_store')
self.config(filesystem_store_datadir=None, group='glance_store')
self.config(filesystem_store_datadirs=None, group='glance_store')
for (__, store_instance) in backend._load_stores(self.conf):
store_instance.configure()
self.assertTrue(mock_log.warning.called)
mock_log.warning.assert_called_once_with(
"Failed to configure store correctly: Store filesystem "
"could not be configured correctly. Reason: Specify "
"at least 'filesystem_store_datadir' or "
"'filesystem_store_datadirs' option Disabling add method.")