Commit Graph

772 Commits (stable/rocky)

Author SHA1 Message Date
Zuul 7cad6da6f1 Merge "Fix python3 compatibility of rbd get_fsid" into stable/rocky 3 years ago
Sean McGinnis ff65eec040
Remove sheepdog tests from zuul config
The sheepdog project is no longer maintained [0], so this removes the
test configuration as part of an effort to clean up those test
definitions. The glance_store support for sheepdog should also be
deprecated and removed, but that will be done separately.


Change-Id: I79d9dbc8f6ebea381d99e96c4ba4194ba0188b8a
Signed-off-by: Sean McGinnis <>
(cherry picked from commit a7a6064e7d)
(cherry picked from commit 27e421af26)
4 years ago
Michal Arbet 7880a5bfa7 Fix python3 compatibility of rbd get_fsid
In python3 conn.get_fsid() is represented as binary.
Because of this, direct_url is corrupted in DB.
This patch is fixing this. More informations in
closing bug.

Closes-Bug: #1816721

Change-Id: I6a89042fae63bf5c9096a6bee6774aebf3f5864b
(cherry picked from commit 9c73370358)
4 years ago
OpenDev Sysadmins 840bbc424e OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at with any
questions you may have.
4 years ago
Brian Rosmaita d001c3c4c9 Add statement explaining "tips" job configuration
The configuration of the periodic "tips" jobs in .zuul.yaml may
be confusing, particularly after a stable branch is cut.   Add a
comment explaining what we're doing and why to reduce confusion.

Change-Id: I7bf676ac972af835c7a6b8d04815629752685765
(cherry picked from commit ad46c752ef)
5 years ago
Zuul 72bd47fcc2 Merge "import zuul job settings from project-config" into stable/rocky 5 years ago
Brian Rosmaita 476b110e5b Refactor periodic "tips" jobs
Two changes:
1 - declare the abstract base tips jobs 'abstract'
2 - add a branch matcher to where the periodic tips jobs
    are invoked in the project definition so that they only
    apply to the master branch

Change-Id: I1093de2583da862f58372e6c03b2d9b604dbd630
(cherry picked from commit 11db636c34)
5 years ago
Nguyen Hai 3a8c9d3cff import zuul job settings from project-config
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project

Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.

Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are

See the python3-first goal document for details:

Change-Id: Ic20de1346896f60817ac940bcf7876ba0bb4de22
Story: #2002586
Task: #24297
5 years ago
Zuul 3e8f3d62be Merge "Add release note for glance_store bugfix release" into stable/rocky 5 years ago
Brian Rosmaita cfd0567b4f Wrap interface function for multihash correctly
The store_add_to_backend_with_multihash() function was not wrapped
correctly so that Glance could consume the secure hash value.  This
patch adds the correct wrapping.

Closes-bug: #1784420

(cherry picked from commit 4d4cf1559c)

Change-Id: I7a94dfffb61fc212abb58c1e1aec5884474b6aa8
5 years ago
Brian Rosmaita 9a0772d118 Add release note for glance_store bugfix release
Change-Id: I6b9d3927f27d9f6c4dc16a45efd5f01fee1555ec
5 years ago
OpenStack Release Bot c9bb21ca15 Update UPPER_CONSTRAINTS_FILE for stable/rocky
The new stable upper-constraints file is only available
after the openstack/requirements repository is branched.
This will happen around the RC1 timeframe.

Recheck and merge this change once the requirements
repository has been branched.

The CI system will work with this patch before the requirements
repository is branched because zuul configues the job to run
with a local copy of the file and defaults to the master branch.
However, accepting the patch will break the test configuration
on developers' local systems, so please wait until after the
requirements repository is branched to merge the patch.

Change-Id: I8da6f0a99a89aaba053ebc9ed03e785b08b1b6dc
5 years ago
OpenStack Release Bot d45bbab614 Update .gitreview for stable/rocky
Change-Id: Ic7fdbe8fab21138326913f308da2255d2d3dd35d
5 years ago
Zuul 7141c77f18 Merge "Consider Cinder back-end as production ready" 5 years ago
Zuul 87c35999cd Merge "Remove config option help translation" 5 years ago
Zuul f84d3044df Merge "Address multi store nits" 5 years ago
Erno Kuvaja 2c35f16ff1 Consider Cinder back-end as production ready
Closes-Bug: #1780764
Change-Id: I02153190d72bd861c509f61caad92c20a787f848
5 years ago
Sean McGinnis 1bbe9b3f8a Remove config option help translation
Config option help is used to generate sample config files.  This
is done statically and only in English. Translation is done
dynamically at runtime by loading the translation catalogs. So
putting the _() translation around config option help creates
unnecessary work for the translators as this will never be loaded
and translated.

This removes translation markers from config option definitions.

Change-Id: I0597a5b69ef4e179324885cb35bbb72fceb2b830
5 years ago
Brian Rosmaita 90f4b82aec Deprecate store_add_to_backend()
A replacement, store_add_to_backend_with_multihash(), has been
introduced in Rocky.  The old function is kept in Rocky for
backward compatability.  This deprecation notice registers our
intent to remove it in Stein.

Change-Id: If09ae10ee160e3fbfafce94e4f3607994af63ec5
5 years ago
Scott McClymont ba9808cebb Multihash Implementation for Glance
Adds the ability to compute a "multihash" (see the Glance spec
for what this is exactly).  To maintain backward compatability,
a new store_add_to_backend_with_multihash function is added.
Backward compatability for each store's add() method is achieved
by a back_compat_add wrapper.

Co-Authored-by: Scott McClymont <>
Co-Authored-by: Brian Rosmaita <>

Change-Id: I063d0900b7dc7e0d94dfb685971eb9b17ed67c7b
Partially-implements: blueprint multihash
5 years ago
Zuul baa663ec5c Merge "Add release notes for 0.25.0" 5 years ago
Zuul 74a0479078 Merge "Multi store support for cinder driver" 5 years ago
Sean McGinnis d4c5fa95e5 Address multi store nits
This addresses some nits from I1f2e8fa61d6dfecd8395a1f894f74ec5bcb5573c
that were not worth holding up that review to address.

Change-Id: Iab60d5622dddf29871fbbc9f51deb93de26235e8
5 years ago
Zuul 7426ad990e Merge "Update to align with openstackdocstheme" 5 years ago
Zuul bc9178a140 Merge "Multi store support for http, swift, sheepdog and vmware driver" 5 years ago
Erno Kuvaja f8ee2fc9ad Add release notes for 0.25.0
Change-Id: I88ee7947d34512276ac5866bf1ada0666f2eaac9
5 years ago
Abhishek Kekane a114c41d11 Multi store support for cinder driver
Added multi store support for cinder driver. The default behavior is
maintained for backward compatibility.

Partial-Implements: bp multi-store

Change-Id: I094d315a5f3968cac2056a42f0a4ac236323f36d
5 years ago
Zuul e5d8f5bf91 Merge "Update links in README" 5 years ago
Zuul b16a0fdeda Merge "Deprecate stores, default_store config options" 5 years ago
Zuul 0d0e4100e2 Merge "Update tox.ini to conform to the PTI" 5 years ago
Zuul 3e1cc3e5e6 Merge "Enable multi store support for glance" 5 years ago
Brian Rosmaita 94ade76bc3 Update tox.ini to conform to the PTI
The current Python Testing Interface specifies the use of
stester, so update tox.ini to use it.

Closes-bug: #1780272
Change-Id: I6b6c60486a26cfbb5793c074fe6f554c6a324846
Co-Authored-By: Nguyen Hai <>
5 years ago
Nguyen Hai b65459e69d Follow the new PTI for document build
For compliance with the Project Testing Interface as described in:

Change-Id: I06d510a44b9e8c0024f5e41f10f4446e18bf86cc
5 years ago
Zuul 0c3a15618b Merge "cinder: Specify mountpoint host param to attach API" 5 years ago
Abhishek Kekane 2636a4121b Multi store support for http, swift, sheepdog and vmware driver
Added multi store support for http, swift, sheepdog and vmware driver.
The default behavior is maintained for backward compatibility.

Partial-Implements: bp multi-store

Change-Id: I93ccdafc6e740065ff4ca3adc6b49eb82e8afa10
5 years ago
Abhishek Kekane 87114c8ec7 Enable multi store support for glance
Added supporting logic to configure, manage and use multiple stores
of the same or different type/scheme. Added new config option
'default_backend' which will be used to specifiy default store
to which image will be stored.

Added support for file and rbd store. The default behavior is
maintained for backward compatibility.

Partial-Implements: bp multi-store

Change-Id: I1f2e8fa61d6dfecd8395a1f894f74ec5bcb5573c
5 years ago
Abhishek Kekane 65959d6393 Deprecate stores, default_store config options
Related to blueprint multi-store-backend-support

Change-Id: I50189862454ada978eb401ec24a46988517ea73b
5 years ago
Tomoki Sekiyama d50ab63e13 specify region on creating cinderclient
If cinder_store_{user_name,password,project_name} are provided,
cinder client will be created without region information.
It may cause wrong region access on some multi-region setup.

This fixes the issue by always passing `cinder_os_region_name`
value to cinderclient.

Change-Id: I835b2f0da03f29245c26c9c531b04de737d8ef5b
Closes-Bug: #1764200
5 years ago
Zuul 92114fb679 Merge "fix tox python3 overrides" 5 years ago
Tomoki Sekiyama 68784feef2 cinder: Specify mountpoint host param to attach API
When an image data is uploaded to cinder backend, it causes the
following error:
  glance_store._drivers.cinder BadRequest:
  Invalid input for field/attribute mountpoint.

This is due to cinder require the mountpoint param on attach API.

Change-Id: Ie82e9f4f3848cebe54f4dbccb9018815a0d5ebf1
Closes-Bug: #1779455
5 years ago
Brian Rosmaita 5a20d47cd3 Deprecate store_capabilities_update_min_interval
Includes a release note.

Change-Id: Ic25549ac022cf7fc93affc331f2379ea63bf6fb2
Implements: blueprint spec-lite-deprecate-update-min-interval
5 years ago
Zuul fd2a80a08f Merge "Disable verification for Keystone session in Swift" 5 years ago
XiaojueGuan 94b27c919c Update links in README
Change the outdated links to the latest links in README

Change-Id: I2dc02780ac7853c8a0e6346509ad894d70a674a8
5 years ago
kairat_kushaev cc97b94903 use only exceptions for uri validations
Currently we use asserts for uri validation, which is not good
practice because assert will be deleted from optimized code.
We must use exceptions in such cases.

Co-authored-by: kairat_kushaev <>
Co-authored-by: Brian Rosmaita <>

Change-Id: I89c5f1b74be89c759d5754d6cab54dc86c946be1
5 years ago
Doug Hellmann 573fde0ff9 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: Ife7b0078c67df55b4b5d5b3d27f4228907a5531b
Signed-off-by: Doug Hellmann <>
5 years ago
liuyamin 557eddffc3 Update to align with openstackdocstheme
Revise the documentation configuration to reflect the latest
guidelines at

Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450
5 years ago
Brian Rosmaita d11bd6a154 Add periodic tips jobs
Add jobs to the periodic queue that run the glance_store unit tests
against the master of various libraries we consume so that we don't
have to wait for a release to detect a change that could be

Change-Id: I0385646991140debc06ea27a194a6e7f6f749e6b
5 years ago
Zuul d79cd98b00 Merge "TrivialFix: Correct reST field lists in docstrings" 5 years ago
Zuul 1cdbe681bb Merge "process spelling error" 5 years ago
Zuul c06e315e87 Merge "Clean imports in code" 5 years ago