Commit Graph

40 Commits (b2e6656d16e655be25a74aa61ac1cb22e0d56016)

Author SHA1 Message Date
liyou01 5ff06df97f Remove Python 2 support
Python 2 has been deprecated for almost two years, and has not been
guaranteed to work with glance_store for a while. This patch removes all
traces of six, unicode strings and Python 2 tweaks.

Co-Authored-By: Cyril Roelandt <>
Change-Id: Ifa78924d7ecf4f2d9a54c677888ab2926530c487
2022-05-25 04:42:06 +02:00
Cyril Roelandt e4930e5dc8 Fix documentation build with Sphinx>=4.2.0
Change-Id: I07b14385290cbaba570115a85233d35a88b4d586
Closes-Bug: #1946789
2021-10-12 21:14:31 +02:00
Rajat Dhasmana 1178f113c4 Add cinder's new attachment support
Cinder introduced new attachment API flow in microversion 3.27
(also attachment_complete added in mv 3.44 and support for passing
mode added in mv 3.54) which provides a clean interface to
interact with cinder for attachments and is also required for
multiattach volume support (Related future work).
Nova uses it since a long time and is proven to be stable,
this patch implements the same for glance.
The create volume and delete volume calls are also moved to
cinder_utils file to use the generic exception handler
and keep similar code together for consistency.

Partially Implements: blueprint attachment-api-and-multiattach-support

Change-Id: I2758ed1d5b8e0981faa3eff6f83e1ce5975a01d2
2021-07-23 10:22:12 -04:00
Andreas Jaeger 7eb1635425 Switch to newer openstackdocstheme and reno versions
Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems

Update Sphinx version as well.

Disable openstackdocs_auto_name to use 'project' variable as name.

Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.

Remove docs requirements from lower-constraints, they are not needed
during install or test but only for docs building.

openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.

See also

Change-Id: Iee357adb23ff65e453ac627eaec0b9d7ac245ba6
2020-05-30 16:57:57 +02:00
whoami-rajat f5d4699613 Add lock per share for cinder nfs mount/umount
With cinder configured as glance store and nfs as cinder backend,
if we create multiple images concurrently into the same share,
there might be race conditions.
This patch ensures a lock per export to avoid the race conditions.

This patch also introduces a reference counting mechamism for unmounting
which will unmount the share if no active thread/process is using it.

Closes-Bug: #1870289

Change-Id: I9197f64e29a0ae2e0a58186f1a70aa134f7f1db6
2020-05-01 11:35:01 +00:00
Andreas Jaeger 8ba16057db Cleanup py27 support
Make a few cleanups:
- Remove python 2.7 stanza from
- Add requires on python >= 3.6 to setup.cfg so that pypi and pip
  know about the requirement
- Remove obsolete sections from setup.cfg:
  * Wheel is not needed for python 3 only repo
- Update classifiers
- Update requirements, no need for python_version anymore

Change-Id: I12ecea6b3cfcca8edd5adedac91f906d77f4ff36
2020-04-05 08:20:21 +02:00
Naohiro Sameshima 261bad3e43 Add S3 store support to glance_store
Revive the S3 driver that was supported up to Mitaka and add multiple
store support to correspond with the features added to glance_store from
Newton to U cycle. In addition, the use of the S3 SDK used by the Mitaka
S3 driver has been deprecated, so this implementation will be changed
to use the new version.

Change-Id: I203134837319080ead96da69048baf90086d2117
Implements: blueprint re-support-s3-driver
2020-03-26 10:53:46 +09:00
Zuul b242a2fabf Merge "Remove sheepdog store driver" 2019-12-19 00:02:39 +00:00
Zuul 864f36f209 Merge "Cap sphinx for py2 to match global requirements" 2019-12-09 16:09:43 +00:00
Abhishek Kekane 5c9db72a93 Remove sheepdog store driver
Change-Id: I0c202cedb1532b9fe44afbb6553e7353185f6238
2019-11-19 06:17:34 +00:00
Brian Rosmaita 579a9284fd Deprecate Sheepdog driver
As there was no response to the ML announcement [0], proceed
with deprecation of the Sheepdog driver, scheduled for removal
in the 'U' cycle.


Change-Id: Ie41b166e51e4d7b674f893c2b71d576e5a8b51a0
2019-07-19 16:38:18 -04:00
zhangboye 9b6931e70c Cap sphinx for py2 to match global requirements
Change-Id: I1055d9e0193a5ad45e441a9faf04c2c787ab5fef
2019-05-16 15:40:43 +08:00
yfzhao 4c328e7630 Update mailinglist from dev to discuss
openstack-dev was decomissioned this night in
Update openstack-dev to openstack-discuss

Co-authored-by: LeopardMa <>

Change-Id: I06acef3eafe1b9f7842636e9bcb5a637f2d78cc3
Closes-Bug: #1808929
2018-12-21 11:11:48 +08:00
Zuul 7426ad990e Merge "Update to align with openstackdocstheme" 2018-07-17 12:48:11 +00:00
Nguyen Hai b65459e69d Follow the new PTI for document build
For compliance with the Project Testing Interface as described in:

Change-Id: I06d510a44b9e8c0024f5e41f10f4446e18bf86cc
2018-07-16 01:26:52 +00:00
liuyamin 557eddffc3 Update to align with openstackdocstheme
Revise the documentation configuration to reflect the latest
guidelines at

Change-Id: Ife99fbc14ef5c03a87428eaf5b3fa62aacda9450
2018-06-06 14:15:32 +08:00
Brian Rosmaita eb6041deb2 Add glance_store disclaimer to docs
Change Iac83c515e12ec953f4814e7cbeeca33c034d7497 added a statement,
agreed upon at the Ocata design summit, concerning the use-at-your-
own-risk nature of glance_store.  This patch updates the glance_store
docs to carry the same disclaimer.

Change-Id: I513fc391246d52fdf08fcd33012c7bbb677a36ac
2018-05-02 12:12:13 -04:00
Hoang Trung Hieu 2a32fb63fa Add doc8 to pep8 check for glance_store project
This patch adds a doc8 check of .rst files to the current pep8 check.
It includes fixes to the .rst files that didn't pass the check.

Co-authored-By: Nguyen Van Trung <>
Change-Id: If35a7a9ea64c7482306ef6403e9585b78da27fb9
2018-02-01 09:11:53 +07:00
liuyamin 06a254e28c Fix some wrong url and add license
Change-Id: I1a1fe5877d277bff10a0879da73b5421228d7cab
2018-01-09 14:24:40 +08:00
Jenkins cc6e90a16f Merge "Removes unnecessary utf-8 coding for glance_store" 2017-07-14 12:37:28 +00:00
Doug Hellmann 51cb0c5a84 switch from oslosphinx to openstackdocstheme
Change-Id: I2a05869c0fb0a5904ef1cc544676954d880332e2
Signed-off-by: Doug Hellmann <>
2017-06-28 10:54:31 -04:00
Doug Hellmann 26a74766f3 rearrange existing documentation according to the new standard layout
Change-Id: I0fb178d0b6ebf7ebafc6e2766c8c5efc5d8cc60e
Signed-off-by: Doug Hellmann <>
2017-06-28 10:54:14 -04:00
luqitao 26241ee5d5 Fix html_last_updated_fmt for Python3
html_last_updated_fmt option is interpreted as a
byte string in python3, causing Sphinx build to break.
This patch makes it utf-8 string.

Change-Id: I8eb08b739d01aa38596d1c92aad9f98cb0ae1eb2
Closes-Bug: #1693670
2017-06-09 04:35:06 -04:00
Tomoki Sekiyama 38eb706ff9 Update maintainer's email address
Update cinder maintainer's email address.

Change-Id: I55cbf6c9f11d02ad93e94e9757ed4873415a9007
2017-03-21 17:23:11 +09:00
gengchc2 c71b2e42d9 Removes unnecessary utf-8 coding for glance_store
The file was added redundant utf-8 coding by some editor.
we can delete it .

Change-Id: I1a87f00e3ca189d249932db7df73e2179415f81e
2017-03-10 01:37:48 +00:00
Thomas Bechtold 34c0108a8a Fix doc build if git is absent
When building packages if git is absent, then we should not set
html_last_updated_fmt. It can still be set via the -D switch
when building with sphinx-build.

Change-Id: Ia63ebf075edeb3aec03c7968efc8ae452a94696b
Closes-Bug: #1552251
2016-09-01 21:55:56 +02:00
Tom Cocozzello 1ce1f40f5a Fix doc generation warnings and errors
When docs are generated with pbr command 'warnerrors = True'
there are many doc problems that are shown. This patch fixes
these problems.

Closes-Bug: #1557234
Change-Id: I05f2f96a582e44be28ab73e0bb80294facf902d5
2016-03-22 13:27:06 +00:00
Tom Cocozzello 5c6c6e6f4c Module docs are not generated
since the pbr section setup.cfg is not defined the module docs
are not being output.  This is also causing dead links in the
driver [0]. Since there is an empty section in the docs [1]
also show the module docs there for ease of use.


Closes-Bug: #1554689
Change-Id: Ia0a81bf9514be1cdd2310c3ec0385470e8f33d51
2016-03-14 18:12:44 -05:00
Jenkins 8a7729110a Merge "Replace deprecated library function os.popen() with subprocess" 2016-01-20 21:38:39 +00:00
Flavio Percoco a3b15e665d Document supported drivers and maintainers
As per the latest communication sent to openstack-dev[0], this commit
adds the list of drivers and maintainers to the glance_store
documentation. The drivers listed here are considered supported by the
overall community but mainly by the listed maintainers.

Drivers that currently exist in the source tree that are not listed here
will be marked as deprecated following what was communicated in the
aforementioned thread[0].


Change-Id: I0ae750a8bbd936e421a5221b7a97fef1f0d02750
2016-01-18 15:47:17 -04:30
LiuNanke 120f25e09b Replace deprecated library function os.popen() with subprocess
os.popen() is deprecated since python 2.6. Resolved with use of
subprocess module.
Closes-Bug: #1529836

Change-Id: Ie98335b65c41906d66abe07989ab014cf079476e
2016-01-09 20:17:02 +08:00
Erno Kuvaja f1f79b898d Rel notes for 0.10.0
7b9bec7 Updated from global requirements
be3d7a6 Remove useless file
b709dd6 vmware: check for response body in error conditions
6993aac remove default=None for config options
341527c Updated from global requirements
2142bd3 Imported Translations from Zanata
fdd725e Updated from global requirements
aa53ea6 Updated from global requirements
d59254e Remove deprecated glance_store opts from default section
6019576 Updated from global requirements
845254f Improving GlanceStoreException
5db9852 Activate pep8 check that _ is imported
a031745 '_' is used by i18n
cc36d53 VMware: Fix missing space in error message
c2b8702 Handle swift store's optional dependency
f37947a Fix swift store tests for latest swiftclient
caf646a Catch InvalidURL when requesting store size

Change-Id: Ib033c82628d9e4024dcb85d776da15670ffc9495
2015-11-25 16:08:03 +00:00
Nikhil Komawar b7d7b8ae5e Release notes 0.9.0 and corrected library version
$ git log --oneline --no-merges 0.8.0..HEAD
eb2ab17 Updated from global requirements
caa3d20 Imported Translations from Transifex
e3b6d64 Add proxy support to S3 Store
3f5a37c Prevent glance-api hangups during connection to rbd

Change-Id: I1a1f983c2146c40bc65ca6975ddaaf664e0e2236
2015-09-02 17:38:10 -04:00
Nikhil Komawar b3f8092b75 Add release notes for 0.6.0
This adds release notes for the following commits:

    $ git log --oneline --no-merges 0.5.0..HEAD
    9d5ceab Drop py26 support
    752f9ca Disable propagating BadStoreConfiguration
    78984a8 Sync up with global-requirements
    f33fe43 Handle optional dependency in vmware store

Change-Id: Iacdea33f8fd2f83fe8b92d0684a3637cef64a4b1
2015-05-28 01:28:32 -04:00
Louis Taylor 56c9486800 Add release notes for 0.5.0
This adds release notes for the following commits:

    $ git log --oneline --no-merges  0.4.0..HEAD
    b0798ac Drop use of 'oslo' namespace package
    751f9ae Fix RBD delete image on creation failure
    73bf032 Use is_valid_ipv6() from oslo.utils
    5c71f1d Properly instantiate Forbidden exception
    19fede3 Update README to work with release tools
    e8884d2 Remove ordereddict from requirements
    dc378a7 gridfs: add pymongo to test-requirements and update tests
    cddecb1 Add release notes for 0.1.10-0.3.0
    774d9ac Only warn on duplicate path on fs backend
    63fcfd5 Propagate BadStoreConfiguration to library user
    4d8a752 Update oslo libraries
    4fba478 Initialize vmware session during store creation

Change-Id: I25b165a9f04b155fe6471665ab346be76963316f
2015-05-12 01:43:51 +01:00
Cindy Pallares cddecb105e Add release notes for 0.1.10-0.3.0
Closes-bug: #1429898

Change-Id: Ib4fa73e43d9fc6e0991332fa1122ae1512233c57
2015-03-31 00:12:46 +00:00
Nikhil Komawar ea88e503b6 Add release notes for 0.4.0
$ git log 0.3.0..HEAD --no-merges --oneline

c89bfe2 Fix intermittent failure in test_vmware_store
f98018c Deprecate the gridfs store
6aa9dd1 Remove incubative openstack.common.context module
4f05481 Update help text with sample conf
2454639 Use oslo_config.cfg.ConfigOpts in glance_store
5121910 Make dependency on boto entirely conditional
b8d6263 Move from oslo.utils to oslo_utils (supplement)
affcd80 Fix timeout during upload from slow resource
8bd848d Throw NotFound exception when template is gone
89e8884 Correct such logic in store.get() when chunk_size param provided

Change-Id: Ie89bdf1c252a41b4c7b7ac40376d254b5f71fc8f
2015-03-18 22:05:58 +00:00
Andreas Jaeger a705bfd7bf Stop using intersphinx
Remove intersphinx from the docs build as it triggers network calls that
occasionally fail, and we don't really use intersphinx (links other
sphinx documents out on the internet)

This also removes the requirement for internet access during docs build.

This can cause docs jobs to fail if the project errors out on

Change-Id: I71e941e2a639641a662a163c682eb86d51de42fb
Related-Bug: #1368910
2014-09-13 09:24:36 +02:00
Flavio Percoco a1c59a1575 Rename to glance_store
Given the existing, known issues, with python namespaces, pip and
setuptools, we've decided to rename into glance_store.

Change-Id: I3f02ce78b3d64f34744e5116652bfbb4f3062cbf
2014-08-28 10:09:36 +02:00
Flavio Percoco 2450528776 Add .gitreview to the repo
This patch also removes `swift` related code until we port it.

Change-Id: I5c78af7334cb39e6d32afe7ca342f91c5521d30b
2014-07-17 11:53:18 +02:00