Cinder introduced new attachment API flow in microversion 3.27
(also attachment_complete added in mv 3.44 and support for passing
mode added in mv 3.54) which provides a clean interface to
interact with cinder for attachments and is also required for
multiattach volume support (Related future work).
Nova uses it since a long time and is proven to be stable,
this patch implements the same for glance.
The create volume and delete volume calls are also moved to
cinder_utils file to use the generic exception handler
and keep similar code together for consistency.
Partially Implements: blueprint attachment-api-and-multiattach-support
flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
Now that we no longer support py27, we can use the standard library
unittest.mock module instead of the third party mock lib.
Signed-off-by: Sean McGinnis <firstname.lastname@example.org>
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found.
Remove hacking and friends from lower-constraints, they are not needed
Revive the S3 driver that was supported up to Mitaka and add multiple
store support to correspond with the features added to glance_store from
Newton to U cycle. In addition, the use of the S3 SDK used by the Mitaka
S3 driver has been deprecated, so this implementation will be changed
to use the new version.
Implements: blueprint re-support-s3-driver
doc8 is not required to use this module, only for style
checking of RST documentation.
Move from requirements.txt -> test-requirements.txt to avoid
generating a run-time dependency on doc8.
The current Python Testing Interface specifies the use of
stester, so update tox.ini to use it.
Co-Authored-By: Nguyen Hai <email@example.com>
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
This patch adds bandit security linter to tox jobs. It ignores
files in the 'tests' directory.
This patch will also fix or exclude any issues as a result from
Make use of the testr OpenStack wrapper ostestr instead of
Signed-off-by: Danny Al-Gaaf <firstname.lastname@example.org>