91 lines
3.0 KiB
Plaintext
91 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a672d9df_582b5c97",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 9303
|
|
},
|
|
"writtenOn": "2024-03-05T05:23:55Z",
|
|
"side": 1,
|
|
"message": "We should report bug in glance-store and backport it to previous release(s) as well",
|
|
"range": {
|
|
"startLine": 7,
|
|
"startChar": 0,
|
|
"endLine": 7,
|
|
"endChar": 2
|
|
},
|
|
"revId": "520076019319da897de5cd4747291b2f1f9aa60e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "301acea5_30c07d4a",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 27615
|
|
},
|
|
"writtenOn": "2024-03-05T12:20:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "a672d9df_582b5c97",
|
|
"range": {
|
|
"startLine": 7,
|
|
"startChar": 0,
|
|
"endLine": 7,
|
|
"endChar": 2
|
|
},
|
|
"revId": "520076019319da897de5cd4747291b2f1f9aa60e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1cfc590f_c3da20ec",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9303
|
|
},
|
|
"writtenOn": "2024-03-05T05:23:55Z",
|
|
"side": 1,
|
|
"message": "Need bug and fix in tests as well.",
|
|
"revId": "520076019319da897de5cd4747291b2f1f9aa60e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "677d68c0_08eab03f",
|
|
"filename": "glance_store/_drivers/cinder/store.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 558,
|
|
"author": {
|
|
"id": 27615
|
|
},
|
|
"writtenOn": "2024-03-04T22:32:11Z",
|
|
"side": 1,
|
|
"message": "When performing upload volume to image operation in optimized way, there is a corner case where this could be problematic.\nIf we don\u0027t set image_upload_use_internal_tenant, then while cloning image-volume, it will have the context\u0027s user and project and we might not be able to fetch the volume if it doesn\u0027t match with the credentials configured on the glance side (if not using context).\n\nHowever, in an ideal deployment, we should always store the image-volumes in internal tenant and the values for internal tenant on cinder side (user: cinder, project: service) should match the ones configured in glance-api.conf file else the image-volume\u0027s will start showing up in user\u0027s project and that could be a vulnerability issue.",
|
|
"range": {
|
|
"startLine": 558,
|
|
"startChar": 12,
|
|
"endLine": 558,
|
|
"endChar": 66
|
|
},
|
|
"revId": "520076019319da897de5cd4747291b2f1f9aa60e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |