138875b7c3
Storage capabilities is used to indicate the static and dynamic ability of the storage driver object based on current driver implementation or particular driver configuration and backend status. Use storage capabilities glance_store can do more proper operations on backend to support upper layer request, like to enable or disable add() function to glance, or if allow glance reuse driver instance for all request according to whether the driver and/or backend is stateless. This patch implemented some initial capabilities for existing drivers, and change the foundational code to make them be aware. Mainly it contains: 1. Implemented essential code to enable driver capabilities, adding necessary capabilities. 2. Added a generic checker on necessary storage operations, to make sure the capabilities of the driver are capable of handling requested operation. We can enhance the check logic as needed easily in future. 3. Added a callback based schedule logic to update dynamic capabilities of store when operator enabled it by a option. 4. Refactoring on existing disablement logic on driver add() interface, to use consistent capabilities way to handle it, removed add_disabled(). 5. Therefor the related exception conversion logic for other interfaces are redundant, due to now we can raise proper exception directly from the checker. 6. Added the logic to recreate drive object if the storage and/or driver isn't stateless. Few minor changes need to be added to Glance side: Change Ibbc85b6bc2ea98c564d316db2874d7df5aac32a6 . docImpact Implements: blueprint store-capabilities Change-Id: Iedf0d4f829e46ca64c3f4fc6a7dfee54d9b0605b Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
127 lines
4.7 KiB
Python
127 lines
4.7 KiB
Python
# Copyright 2014 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import pkg_resources
|
|
from testtools import matchers
|
|
|
|
from glance_store import backend
|
|
from glance_store.tests import base
|
|
|
|
|
|
class OptsTestCase(base.StoreBaseTest):
|
|
|
|
def _check_opt_groups(self, opt_list, expected_opt_groups):
|
|
self.assertThat(opt_list, matchers.HasLength(len(expected_opt_groups)))
|
|
|
|
groups = [g for (g, _l) in opt_list]
|
|
self.assertThat(groups, matchers.HasLength(len(expected_opt_groups)))
|
|
|
|
for idx, group in enumerate(groups):
|
|
self.assertEqual(expected_opt_groups[idx], group)
|
|
|
|
def _check_opt_names(self, opt_list, expected_opt_names):
|
|
opt_names = [o.name for (g, l) in opt_list for o in l]
|
|
self.assertThat(opt_names, matchers.HasLength(len(expected_opt_names)))
|
|
|
|
for opt in opt_names:
|
|
self.assertIn(opt, expected_opt_names)
|
|
|
|
def _test_entry_point(self, namespace,
|
|
expected_opt_groups, expected_opt_names):
|
|
opt_list = None
|
|
for ep in pkg_resources.iter_entry_points('oslo.config.opts'):
|
|
if ep.name == namespace:
|
|
list_fn = ep.load()
|
|
opt_list = list_fn()
|
|
break
|
|
|
|
self.assertIsNotNone(opt_list)
|
|
|
|
self._check_opt_groups(opt_list, expected_opt_groups)
|
|
self._check_opt_names(opt_list, expected_opt_names)
|
|
|
|
def test_list_api_opts(self):
|
|
opt_list = backend._list_opts()
|
|
expected_opt_groups = ['glance_store', 'glance_store']
|
|
expected_opt_names = [
|
|
'default_store',
|
|
'stores',
|
|
'store_capabilities_update_min_interval',
|
|
'cinder_api_insecure',
|
|
'cinder_ca_certificates_file',
|
|
'cinder_catalog_info',
|
|
'cinder_endpoint_template',
|
|
'cinder_http_retries',
|
|
'default_swift_reference',
|
|
'filesystem_store_datadir',
|
|
'filesystem_store_datadirs',
|
|
'filesystem_store_file_perm',
|
|
'filesystem_store_metadata_file',
|
|
'mongodb_store_db',
|
|
'mongodb_store_uri',
|
|
'os_region_name',
|
|
'rbd_store_ceph_conf',
|
|
'rbd_store_chunk_size',
|
|
'rbd_store_pool',
|
|
'rbd_store_user',
|
|
's3_store_access_key',
|
|
's3_store_bucket',
|
|
's3_store_bucket_url_format',
|
|
's3_store_create_bucket_on_put',
|
|
's3_store_host',
|
|
's3_store_object_buffer_dir',
|
|
's3_store_secret_key',
|
|
's3_store_large_object_size',
|
|
's3_store_large_object_chunk_size',
|
|
's3_store_thread_pools',
|
|
'sheepdog_store_address',
|
|
'sheepdog_store_chunk_size',
|
|
'sheepdog_store_port',
|
|
'swift_store_admin_tenants',
|
|
'swift_store_auth_address',
|
|
'swift_store_cacert',
|
|
'swift_store_auth_insecure',
|
|
'swift_store_auth_version',
|
|
'swift_store_config_file',
|
|
'swift_store_container',
|
|
'swift_store_create_container_on_put',
|
|
'swift_store_endpoint',
|
|
'swift_store_endpoint_type',
|
|
'swift_store_key',
|
|
'swift_store_large_object_chunk_size',
|
|
'swift_store_large_object_size',
|
|
'swift_store_multi_tenant',
|
|
'swift_store_multiple_containers_seed',
|
|
'swift_store_region',
|
|
'swift_store_retry_get_count',
|
|
'swift_store_service_type',
|
|
'swift_store_ssl_compression',
|
|
'swift_store_user',
|
|
'vmware_api_insecure',
|
|
'vmware_api_retry_count',
|
|
'vmware_datacenter_path',
|
|
'vmware_datastore_name',
|
|
'vmware_server_host',
|
|
'vmware_server_password',
|
|
'vmware_server_username',
|
|
'vmware_store_image_dir',
|
|
'vmware_task_poll_interval'
|
|
]
|
|
|
|
self._check_opt_groups(opt_list, expected_opt_groups)
|
|
self._check_opt_names(opt_list, expected_opt_names)
|
|
self._test_entry_point('glance.store',
|
|
expected_opt_groups, expected_opt_names)
|