openstack/goal-tools
Code Issues Proposed changes

clean up 'patches list' output

Browse Source 
remove newline in URL so that each item is on a line by itself

add blank line between patches and summary

Change-Id: Ie4feb0fdc34edbe5681ba58c8e0828e2e4d0f18d
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-08-05 13:37:19 -04:00
parent 8b74ee2025
commit 09b8768fbb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
goal_tools/python3_first/patches.py
View File

@ -101,7 +101,7 @@ def format_votes(votes):
def get_one_row(change):
subject = change['subject'].rstrip()
repo = change.get('project')
url = 'https://review.openstack.org/{}\n'.format(change['_number'])
url = 'https://review.openstack.org/{}'.format(change['_number'])
status = change.get('status')
branch = change.get('branch')
if status not in ('ABANDONED', 'MERGED'):
@ -113,7 +113,7 @@ def get_one_row(change):
status = 'negative vote'
elif code_review.get(1):
status = 'REVIEWED'
return (subject.strip(), repo, status, url, branch)
return (subject, repo, status, url, branch)
class PatchesList(lister.Lister):
@ -159,6 +159,7 @@ class PatchesList(lister.Lister):
for row in rows:
counts.update({row[2]: 1})
yield row
yield ('', '', '', '', '')
for status, n in sorted(counts.items()):
yield ('', '', status, str(n), '')