Update patch set 2
Patch Set 2: -Code-Review Rollcall-Vote+1 (3 comments) Patch-set: 2 Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=0, 75c483f14b75df0f282e20336ae467819fcd037e Label: Rollcall-Vote=+1, 5aaf85faaf155aac728f8556495fed20c1b27979 Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
parent
850234fe4f
commit
0df8e07652
@ -35,6 +35,24 @@
|
|||||||
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"unresolved": true,
|
||||||
|
"key": {
|
||||||
|
"uuid": "9d39d2eb_d97f8d8e",
|
||||||
|
"filename": "/COMMIT_MSG",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 13,
|
||||||
|
"author": {
|
||||||
|
"id": 13252
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-14T09:31:03Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I\u0027m fine with that change, I just think it should be mentioned here.",
|
||||||
|
"parentUuid": "8626200d_6d09eb2e",
|
||||||
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"unresolved": false,
|
"unresolved": false,
|
||||||
"key": {
|
"key": {
|
||||||
@ -105,6 +123,23 @@
|
|||||||
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "32e5b6e3_a9c8c816",
|
||||||
|
"filename": "/PATCHSET_LEVEL",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 0,
|
||||||
|
"author": {
|
||||||
|
"id": 13252
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-14T09:31:03Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "sorry I missed your replies earlier, comments inline but I\u0027d also agree to move on with this as is if you prefer",
|
||||||
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"unresolved": true,
|
"unresolved": true,
|
||||||
"key": {
|
"key": {
|
||||||
@ -174,6 +209,24 @@
|
|||||||
"parentUuid": "6c374af4_a2639c19",
|
"parentUuid": "6c374af4_a2639c19",
|
||||||
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"unresolved": false,
|
||||||
|
"key": {
|
||||||
|
"uuid": "af3efeed_2018cec3",
|
||||||
|
"filename": "reference/projects.yaml",
|
||||||
|
"patchSetId": 2
|
||||||
|
},
|
||||||
|
"lineNbr": 1844,
|
||||||
|
"author": {
|
||||||
|
"id": 13252
|
||||||
|
},
|
||||||
|
"writtenOn": "2024-03-14T09:31:03Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "my main issue was just about how this change is to be classified in terms of the TC handling it, but since Jay has already adapted to topic, this is fine for me as it stands",
|
||||||
|
"parentUuid": "2c49a16c_cc4313fa",
|
||||||
|
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
Loading…
Reference in New Issue
Block a user