From 271eada15d2f67ac2f33a30299253dfce99a84a1 Mon Sep 17 00:00:00 2001 From: Doug Hellmann Date: Wed, 7 Nov 2018 08:44:13 -0500 Subject: [PATCH] mark yamlutils module as private Prefix the module name with an underscore to indicate that it is not meant to be used by things outside of the library. Change-Id: Id37e69dc5b643bd7276d25352d63547dff572238 Signed-off-by: Doug Hellmann --- .../{yamlutils.py => _yamlutils.py} | 0 openstack_governance/governance.py | 14 +++++++------- openstack_governance/tests/test_governance.py | 8 ++++---- 3 files changed, 11 insertions(+), 11 deletions(-) rename openstack_governance/{yamlutils.py => _yamlutils.py} (100%) diff --git a/openstack_governance/yamlutils.py b/openstack_governance/_yamlutils.py similarity index 100% rename from openstack_governance/yamlutils.py rename to openstack_governance/_yamlutils.py diff --git a/openstack_governance/governance.py b/openstack_governance/governance.py index d4fe999f0..7fa082496 100644 --- a/openstack_governance/governance.py +++ b/openstack_governance/governance.py @@ -17,7 +17,7 @@ import logging import os.path import weakref -from openstack_governance import yamlutils +from openstack_governance import _yamlutils import requests @@ -122,13 +122,13 @@ class Governance(object): @classmethod def from_local_repo(cls, repo_dir='.'): team_filename = os.path.join(repo_dir, cls._projects_filename) - team_data = yamlutils.load_from_file(team_filename) + team_data = _yamlutils.load_from_file(team_filename) tc_filename = os.path.join(repo_dir, cls._tc_repos_filename) - tc_data = yamlutils.load_from_file(tc_filename) + tc_data = _yamlutils.load_from_file(tc_filename) sigs_filename = os.path.join(repo_dir, cls._sigs_repos_filename) - sigs_data = yamlutils.load_from_file(sigs_filename) + sigs_data = _yamlutils.load_from_file(sigs_filename) return cls(team_data, tc_data, sigs_data) @@ -137,17 +137,17 @@ class Governance(object): team_url = REPO_URL_BASE + '/reference/projects.yaml' LOG.debug('fetching team data from %s', team_url) r = requests.get(team_url) - team_data = yamlutils.loads(r.text) + team_data = _yamlutils.loads(r.text) tc_url = REPO_URL_BASE + '/reference/technical-committee-repos.yaml' LOG.debug('fetching TC data from %s', tc_url) r = requests.get(tc_url) - tc_data = yamlutils.loads(r.text) + tc_data = _yamlutils.loads(r.text) sigs_url = REPO_URL_BASE + '/reference/sigs-repos.yaml' LOG.debug('fetching SIGs data from %s', sigs_url) r = requests.get(sigs_url) - sigs_data = yamlutils.loads(r.text) + sigs_data = _yamlutils.loads(r.text) return cls(team_data, tc_data, sigs_data) diff --git a/openstack_governance/tests/test_governance.py b/openstack_governance/tests/test_governance.py index 2d71f0209..e211c87f7 100644 --- a/openstack_governance/tests/test_governance.py +++ b/openstack_governance/tests/test_governance.py @@ -14,8 +14,8 @@ from oslotest import base +from openstack_governance import _yamlutils from openstack_governance import governance -from openstack_governance import yamlutils _team_data_yaml = """ @@ -73,9 +73,9 @@ api: - repo: openstack/api-sig """ -TEAM_DATA = yamlutils.loads(_team_data_yaml) -TC_DATA = yamlutils.loads(_tc_data_yaml) -SIGS_DATA = yamlutils.loads(_sigs_data_yaml) +TEAM_DATA = _yamlutils.loads(_team_data_yaml) +TC_DATA = _yamlutils.loads(_tc_data_yaml) +SIGS_DATA = _yamlutils.loads(_sigs_data_yaml) class TestGetRepoOwner(base.BaseTestCase):