From 27f9b2fd3ff928c59c8358c4e0de3aae6d60cdde Mon Sep 17 00:00:00 2001 From: Doug Hellmann Date: Mon, 9 Sep 2019 13:56:48 -0400 Subject: [PATCH] document house rules for approving election results There is no reason to treat election results as requiring a formal vote, so document them as a special case under house rules, along with the reasoning. Update the review status tool to reflect this change. Change-Id: If907b2f4627da289f76e3a8b92d49f08a116535d Signed-off-by: Doug Hellmann --- reference/house-rules.rst | 15 +++++++++++++++ tools/check_review_status.py | 4 +++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/reference/house-rules.rst b/reference/house-rules.rst index 8419ed353..c45c90616 100644 --- a/reference/house-rules.rst +++ b/reference/house-rules.rst @@ -42,6 +42,21 @@ etc.), follow the normal code review rules (with RollCall votes being considered +-2): change will be approved once 2 `RollCall+1` (other than the change owner) are posted (and no `RollCall-1`). +Election Results +---------------- + +:Gerrit topic: ``election-results`` + +The results of elections are documented in the `openstack/governance` +repository, but are not subject to "review" or "approval" by the TC, +other than to confirm that they accurately reflect the outcome of the +election. Patches to update those results for TC and PTL elections +should be reviewed and confirmed by the election officials, and then +approved and merged following the normal code review rules (with +RollCall votes being considered +-2): change will be approved once 2 +`RollCall+1` (other than the change owner) are posted (and no +`RollCall-1`). + Delegated tags -------------- diff --git a/tools/check_review_status.py b/tools/check_review_status.py index 0854f0f31..ab8133c6e 100755 --- a/tools/check_review_status.py +++ b/tools/check_review_status.py @@ -317,8 +317,10 @@ def get_one_status(change, delegates, tc_members): else: can_approve = 'YES' - elif topic in ('code-change', 'documentation-change'): + elif topic in ('code-change', 'documentation-change', 'election-results'): # https://governance.openstack.org/tc/reference/house-rules.html#code-changes + # https://governance.openstack.org/tc/reference/house-rules.html#documentation-changes + # https://governance.openstack.org/tc/reference/house-rules.html#election-results if votes[-1] or code_reviews[-1]: can_approve = 'dissenting votes' elif votes[1] < 2: