From 79fd6a86f35f1a88349dd48cd93d027a2856f8c9 Mon Sep 17 00:00:00 2001 From: Mohammed Naser Date: Thu, 18 Jun 2020 10:44:57 -0400 Subject: [PATCH] tools: update check-review-status to drop grace period We've decided that we're removing grace period on resolutions and this patch updates the tooling to reflect that. Depends-On: https://review.opendev.org/735361 Change-Id: I74583fb696356a00cef898647b135c2476936305 --- tools/check_review_status.py | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/tools/check_review_status.py b/tools/check_review_status.py index 9b87ac69f..643fd1591 100755 --- a/tools/check_review_status.py +++ b/tools/check_review_status.py @@ -35,10 +35,6 @@ TC_SIZE = 11 # before it can be approved creation_age_threshold = datetime.timedelta(days=7) -# For formal-vote votes, age in days since a change has reached a -# the necessary amount of votes before it can be approved -reached_votes_age_threshold = datetime.timedelta(days=3) - def decode_json(raw): """Trap JSON decoding failures and provide more detailed errors @@ -245,17 +241,10 @@ def get_one_status(change, delegates, tc_members): creation_age_threshold.days) earliest = str(latest_created + creation_age_threshold) elif reached_necessary_votes: - # Wait at least reached_votes_age_threshold days - # after reaching necessary votes. - earliest = str( - reached_necessary_votes + reached_votes_age_threshold - ) - since_necessary_votes = now.date() - reached_necessary_votes.date() - time_to_approve = since_necessary_votes > reached_votes_age_threshold + time_to_approve = True else: time_to_approve = False - earliest = "{} days after {} positive votes".format( - reached_votes_age_threshold.days, necessary_votes) + earliest = "after {} positive votes".format(necessary_votes) if votes_to_approve and time_to_approve: parts.append('YES')