openstack/governance
Code Issues Proposed changes

ensure the topic is set to a valid default string

Browse Source 
If a topic is not set, the field is not present in the change and we
get None instead of an empty string. That causes a failure later when
we try to join the value together with other strings.

Change-Id: Id472afa00aa21b55046aea87f90c1f02fd614744
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-09-25 13:58:58 -04:00
parent 4c5dc6bd80
commit 4e8975a651
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/check_review_status.py
View File

@ -152,7 +152,7 @@ def all_changes():
def get_one_status(change, delegates):
topic = change.get('topic')
topic = change.get('topic', 'unknown topic')
subject = change.get('subject')
owner = change.get('owner', {}).get('name')
url = 'https://review.openstack.org/{}\n'.format(change['_number'])