openstack
/
governance
Code Issues Proposed changes

Update patch set 19 

Patch Set 19: Rollcall-Vote+1

(4 comments)

Patch-set: 19
Reviewer: Gerrit User 11975 <11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Rollcall-Vote=+1, 0f135aa3f8730a3c10fe24c5afe2202616bc9a6f
Attention: {"person_ident":"Gerrit User 11975 \u003c11975@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11975\u003e replied on the change"}
This commit is contained in:
Gerrit User 11975 2024-04-03 10:18:02 +00:00 committed by Gerrit Code Review
parent d8a106b675
commit 86a12cd4fc
2 changed files with 79 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
9999cef65230d871c3d808908ae54e8432503824 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "bf17984a_3b023ceb",
"filename": "goals/proposed/migrate-eventlet-usages-to-asyncio.rst",
"patchSetId": 19
},
"lineNbr": 491,
"author": {
"id": 11975
},
"writtenOn": "2024-04-03T10:18:02Z",
"side": 1,
"message": "this link gives me 404 error :/",
"revId": "9999cef65230d871c3d808908ae54e8432503824",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "24442df8_776d8486",
"filename": "goals/proposed/migrate-eventlet-usages-to-asyncio.rst",
"patchSetId": 19
},
"lineNbr": 758,
"author": {
"id": 11975
},
"writtenOn": "2024-04-03T10:18:02Z",
"side": 1,
"message": "nitty nit: trailing space",
"revId": "9999cef65230d871c3d808908ae54e8432503824",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "881ef7ef_4ed8a2eb",
"filename": "goals/proposed/migrate-eventlet-usages-to-asyncio.rst",
"patchSetId": 19
},
"lineNbr": 1081,
"author": {
"id": 11975
},
"writtenOn": "2024-04-03T10:18:02Z",
"side": 1,
"message": "I\u0027m not english native spreaker but shouldn\u0027t be \u0027which\u0027 here?",
"range": {
"startLine": 1081,
"startChar": 656,
"endLine": 1081,
"endChar": 659
},
"revId": "9999cef65230d871c3d808908ae54e8432503824",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
bbaae17cf99a1eca1f59dc22aa9c2ddfaf3e8a3f
View File

@ -138,6 +138,24 @@
"revId": "bbaae17cf99a1eca1f59dc22aa9c2ddfaf3e8a3f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "54bb8107_aa716801",
"filename": "goals/proposed/migrate-eventlet-usages-to-asyncio.rst",
"patchSetId": 16
},
"lineNbr": 420,
"author": {
"id": 11975
},
"writtenOn": "2024-04-03T10:18:02Z",
"side": 1,
"message": "+1",
"parentUuid": "c997b866_6aa8b9ae",
"revId": "bbaae17cf99a1eca1f59dc22aa9c2ddfaf3e8a3f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {