openstack/governance
Code Issues Proposed changes

Merge "document house rules for approving election results"

Browse Source
This commit is contained in:
Zuul
2019-09-17 22:57:57 +00:00
committed by Gerrit Code Review
parent cb3e752fb8 27f9b2fd3f
commit 9c10b108d7
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
reference/house-rules.rst
View File

@@ -43,6 +43,21 @@ etc.), follow the normal code review rules (with RollCall votes being
considered +-2): change will be approved once 2 `RollCall+1` (other
than the change owner) are posted (and no `RollCall-1`).
Election Results
----------------
:Gerrit topic: ``election-results``
The results of elections are documented in the `openstack/governance`
repository, but are not subject to "review" or "approval" by the TC,
other than to confirm that they accurately reflect the outcome of the
election. Patches to update those results for TC and PTL elections
should be reviewed and confirmed by the election officials, and then
approved and merged following the normal code review rules (with
RollCall votes being considered +-2): change will be approved once 2
`RollCall+1` (other than the change owner) are posted (and no
`RollCall-1`).
Delegated tags
--------------

4
tools/check_review_status.py
View File

@@ -317,8 +317,10 @@ def get_one_status(change, delegates, tc_members):
else:
can_approve = 'YES'
elif topic in ('code-change', 'documentation-change'):
elif topic in ('code-change', 'documentation-change', 'election-results'):
# https://governance.openstack.org/tc/reference/house-rules.html#code-changes
# https://governance.openstack.org/tc/reference/house-rules.html#documentation-changes
# https://governance.openstack.org/tc/reference/house-rules.html#election-results
if votes[-1] or code_reviews[-1]:
can_approve = 'dissenting votes'
elif votes[1] < 2: