Update patch set 2

Patch Set 2: Code-Review-1

(4 comments)

Patch-set: 2
Reviewer: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 9a4b9cda146e2974fa09d022eb2994c235b1eb10
This commit is contained in:
Gerrit User 13252 2024-03-07 08:42:43 +00:00 committed by Gerrit Code Review
parent 08dfc9e4e4
commit b02edf17d7
1 changed files with 68 additions and 0 deletions

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e5c14794_fbffea74",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 13,
"author": {
"id": 13252
},
"writtenOn": "2024-03-07T08:42:43Z",
"side": 1,
"message": "this should also at least mention the mission change and how it is related?",
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -52,6 +69,57 @@
"parentUuid": "6a4544d5_ed1eb78e",
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "98075075_bf566973",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2024-03-07T08:42:43Z",
"side": 1,
"message": "-1 just for visibility",
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dc20c60d_ff591538",
"filename": "reference/projects.yaml",
"patchSetId": 2
},
"lineNbr": 1839,
"author": {
"id": 13252
},
"writtenOn": "2024-03-07T08:42:43Z",
"side": 1,
"message": "can we change this line, too, or is it tied to other things too much? does seem inconsistent in the current state",
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6c374af4_a2639c19",
"filename": "reference/projects.yaml",
"patchSetId": 2
},
"lineNbr": 1844,
"author": {
"id": 13252
},
"writtenOn": "2024-03-07T08:42:43Z",
"side": 1,
"message": "I think that this qualifies as \"significant team mission statement change\", which would make this patch require a formal vote.\n\nmight even be better to split into a dedicated patch for clarity",
"revId": "112e70f624008d352466618a64336a9c7f4811bc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}